r77264 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77263‎ | r77264 | r77265 >
Date:23:06, 24 November 2010
Author:catrope
Status:ok
Tags:
Comment:
1.16wmf4: Fix r77262 some more with parentheses
Modified paths:
  • /branches/wmf/1.16wmf4/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/includes/media/Bitmap.php
@@ -159,9 +159,9 @@
160160 // a pixel.
161161 " -thumbnail " . wfEscapeShellArg( "{$physicalWidth}x{$physicalHeight}!" ) .
162162 // Add the source url as a comment to the thumb, but don't add the flag if there's no comment
163 - $comment !== ''
 163+ ( $comment !== ''
164164 ? " -set comment " . wfEscapeShellArg( $this->escapeMagickProperty( $comment ) )
165 - : '' .
 165+ : '' ) .
166166 " -depth 8 $sharpen " .
167167 wfEscapeShellArg( $this->escapeMagickOutput( $dstPath ) ) . " 2>&1";
168168 wfDebug( __METHOD__.": running ImageMagick: $cmd\n" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r77280Fix r77261 by adding the parentheses already added in 1.16wmf4 in r77264catrope12:34, 25 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r772621.16wmf4: MFT r77261 (by hand, because the code is so different that automati...catrope22:55, 24 November 2010

Status & tagging log