r77263 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77262‎ | r77263 | r77264 >
Date:23:02, 24 November 2010
Author:catrope
Status:ok
Tags:
Comment:
1.16wmf4: Fix $params['comment'] vs. $comment issue in r77262
Modified paths:
  • /branches/wmf/1.16wmf4/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/includes/media/Bitmap.php
@@ -159,8 +159,8 @@
160160 // a pixel.
161161 " -thumbnail " . wfEscapeShellArg( "{$physicalWidth}x{$physicalHeight}!" ) .
162162 // Add the source url as a comment to the thumb, but don't add the flag if there's no comment
163 - $params['comment'] !== ''
164 - ? " -set comment " . wfEscapeShellArg( $this->escapeMagickProperty( $params['comment'] ) )
 163+ $comment !== ''
 164+ ? " -set comment " . wfEscapeShellArg( $this->escapeMagickProperty( $comment ) )
165165 : '' .
166166 " -depth 8 $sharpen " .
167167 wfEscapeShellArg( $this->escapeMagickOutput( $dstPath ) ) . " 2>&1";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r772621.16wmf4: MFT r77261 (by hand, because the code is so different that automati...catrope22:55, 24 November 2010

Status & tagging log