r77118 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77117‎ | r77118 | r77119 >
Date:23:22, 22 November 2010
Author:tparscal
Status:ok
Tags:
Comment:
Updated use of placeholder plugin, as of r76987 the plugin expects the attribute to be set rather than accepting the attribute as a parameter.
Modified paths:
  • /trunk/extensions/Vector/modules/ext.vector.simpleSearch.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Vector/modules/ext.vector.simpleSearch.js
@@ -35,7 +35,9 @@
3636 }
3737
3838 // Placeholder text for SimpleSearch box
39 - $( 'div#simpleSearch > input#searchInput' ).placeholder( mediaWiki.msg( 'vector-simplesearch-search' ) );
 39+ $( 'div#simpleSearch > input#searchInput' )
 40+ .val( mediaWiki.msg( 'vector-simplesearch-search' ) )
 41+ .placeholder();
4042
4143 // General suggestions functionality for all search boxes
4244 $( '#searchInput, #searchInput2, #powerSearchText, #searchText' )

Follow-up revisions

RevisionCommit summaryAuthorDate
r77125Fixes previous commit (r77118) which set the value instead of the placeholder...tparscal00:50, 23 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76987jquery.placeholder.js rewritten...krinkle00:12, 19 November 2010

Status & tagging log