r77125 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77124‎ | r77125 | r77126 >
Date:00:50, 23 November 2010
Author:tparscal
Status:ok
Tags:
Comment:
Fixes previous commit (r77118) which set the value instead of the placeholder attribute.
Modified paths:
  • /trunk/extensions/Vector/modules/ext.vector.simpleSearch.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Vector/modules/ext.vector.simpleSearch.js
@@ -36,7 +36,7 @@
3737
3838 // Placeholder text for SimpleSearch box
3939 $( 'div#simpleSearch > input#searchInput' )
40 - .val( mediaWiki.msg( 'vector-simplesearch-search' ) )
 40+ .attr( 'placeholder', mediaWiki.msg( 'vector-simplesearch-search' ) )
4141 .placeholder();
4242
4343 // General suggestions functionality for all search boxes

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77118Updated use of placeholder plugin, as of r76987 the plugin expects the attrib...tparscal23:22, 22 November 2010

Status & tagging log