r76885 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76884‎ | r76885 | r76886 >
Date:16:15, 17 November 2010
Author:demon
Status:ok
Tags:
Comment:
* Per CR on r62646, formatNum() $revCount
* Followup r62887, intval() the result, just in case :)
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -16,7 +16,7 @@
1717 }
1818
1919 function execute() {
20 - global $wgOut, $wgUser, $wgRequest;
 20+ global $wgOut, $wgUser, $wgRequest, $wgLang;
2121 if ( !$this->mRepo ) {
2222 $view = new CodeRepoListView();
2323 $view->execute();
@@ -49,7 +49,7 @@
5050 $wgOut->addHTML(
5151 $navBar .
5252 '<table><tr><td>' . $limitForm . '</td>' .
53 - '<td>&#160;<strong>' . wfMsgHtml( 'code-rev-total', $revCount ) . '</strong></td>' .
 53+ '<td>&#160;<strong>' . wfMsgHtml( 'code-rev-total', $wgLang->formatNum( $revCount ) ) . '</strong></td>' .
5454 '</tr></table>' .
5555 Xml::openElement( 'form',
5656 array( 'action' => $pager->getTitle()->getLocalURL(), 'method' => 'post' )
@@ -203,7 +203,7 @@
204204 $whereCond = array_merge( $whereCond, $this->getSpecializedWhereClause( $dbr ) );
205205 $result = $dbr->selectRow( $tables, $selectFields, $whereCond );
206206 if ( $result ) {
207 - return $result->rev_count;
 207+ return intval( $result->rev_count );
208208 } else {
209209 return 0;
210210 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62646Empty string checks fixed. Display of total counts fixed.pdhanda18:23, 17 February 2010
r62887* CodeRevisionListView::getRevCountQuery renamed to CodeRevisionListView::get...btongminh19:34, 23 February 2010

Status & tagging log