r76884 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76883‎ | r76884 | r76885 >
Date:13:59, 17 November 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Partial revert of r76265, which broke backard compatibility
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_Outputs.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_List.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_List.php
@@ -98,6 +98,8 @@
9999 // Print header
100100 $result = $header;
101101
 102+ $column_width = 0;
 103+
102104 // Set up floating divs, if there's more than one column
103105 if ( $this->mColumns > 1 ) {
104106 $column_width = floor( 100 / $this->mColumns );
Index: trunk/extensions/SemanticMediaWiki/includes/SMW_Outputs.php
@@ -73,7 +73,7 @@
7474 }
7575 }
7676 else { // normal case: treat ID as a ResourceLoader ID
77 - self::requireResource( $id );
 77+ self::$mHeadItems[$id] = $item;
7878 }
7979 }
8080

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76265Improve ResourceLoader compatibility for extensions that use SMW's existing (...mkroetzsch20:06, 7 November 2010

Status & tagging log