| Index: trunk/extensions/CodeReview/CodeReview.i18n.php |
| — | — | @@ -78,7 +78,7 @@ |
| 79 | 79 | 'code-rev-diff-link' => 'diff', |
| 80 | 80 | 'code-rev-diff-too-large' => 'The diff is too large to display.', |
| 81 | 81 | 'code-rev-purge-link' => 'purge', |
| 82 | | - 'code-rev-total' => 'Total number of results: ', |
| | 82 | + 'code-rev-total' => 'Total number of results: $1', |
| 83 | 83 | 'code-status-new' => 'new', |
| 84 | 84 | 'code-status-fixme' => 'fixme', |
| 85 | 85 | 'code-status-reverted' => 'reverted', |
| Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php |
| — | — | @@ -50,7 +50,7 @@ |
| 51 | 51 | $pager->getNavigationBar() . |
| 52 | 52 | $pager->getLimitForm() . |
| 53 | 53 | '</td><td style="padding-left: 2em;">' . |
| 54 | | - ' ' . wfMsgHtml( 'code-rev-total' ) . '<span style="font-weight: bold;">' . $revCount . '</span>' . |
| | 54 | + ' <strong>' . wfMsgHtml( 'code-rev-total', $revCount ) . '</strong>' . |
| 55 | 55 | '</td></tr></table>' . |
| 56 | 56 | Xml::openElement( 'form', |
| 57 | 57 | array( 'action' => $pager->getTitle()->getLocalURL(), 'method' => 'post' ) |
| — | — | @@ -164,7 +164,7 @@ |
| 165 | 165 | $tables = array( 'code_rev' ); |
| 166 | 166 | $selectFields = array( 'COUNT( DISTINCT cr_id ) AS rev_count' ); |
| 167 | 167 | // count if code_rev where path matches |
| 168 | | - if ( $this->mPath ) { |
| | 168 | + if ( strlen($this->mPath) ) { |
| 169 | 169 | $tables[] = 'code_paths'; |
| 170 | 170 | $whereCond = array('cr_repo_id' => $this->mRepo->getId(), |
| 171 | 171 | 'cr_id = cp_rev_id', |
| — | — | @@ -268,7 +268,7 @@ |
| 269 | 269 | |
| 270 | 270 | function formatRevValue( $name, $value, $row ) { |
| 271 | 271 | global $wgUser, $wgLang; |
| 272 | | - $pathQuery = (empty($this->mView->mPath)) ? array() : array('path' => $this->mView->mPath); |
| | 272 | + $pathQuery = ( strlen($this->mView->mPath) ) ? array('path' => $this->mView->mPath) : array(); |
| 273 | 273 | |
| 274 | 274 | switch( $name ) { |
| 275 | 275 | case 'selectforchange': |