r76571 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r76570‎ | r76571 | r76572 >
Date:12:48, 12 November 2010
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
Apply live hack: more shell memory needed.
Modified paths:
  • /trunk/extensions/Translate/scripts/export.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/scripts/export.php
——@@ -127,7 +127,7 @@
128128 global $wgMaxShellMemory;
129129
130130 // Need more shell memory for msgmerge.
131 - $wgMaxShellMemory = 302400;
 131+ $wgMaxShellMemory = 402400;
132132
133133 $conf = $group->getConfiguration();
134134 $definitionFile = str_replace( '%GROUPROOT%', $options['ppgettext'], $conf['FILES']['definitionFile'] );

Comments

#Comment by Reedy (talk | contribs)   16:05, 12 November 2010

Wouldn't it be nicer not to use magic numbers?

So use 400 * 1024 or similar...

#Comment by Nikerabbit (talk | contribs)   16:10, 12 November 2010

The bigger question is can we move the memory setting nearer to the msgmerge call.

#Comment by Siebrand (talk | contribs)   17:08, 12 November 2010

Feel free to experiment.

Command on translatewiki shell is: php $SCRIPTPATH/export.php --target=$EXPORTPATH/ --lang=* --skip=en,qqq --threshold=35 --ppgettext=$HOME --grouptrail=out-statusnet (taken from /home/betawiki/bin/bxa)

Status & tagging log