r76570 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76569‎ | r76570 | r76571 >
Date:12:16, 12 November 2010
Author:raymond
Status:resolved (Comments)
Tags:
Comment:
Follow-up r76434: Run hook for Modern skin too per suggestion of Jack Phoenix
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/skins/Modern.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Modern.php
@@ -27,7 +27,9 @@
2828 */
2929 function getPoweredBy() {
3030 global $wgVersion;
31 - return "<div class='mw_poweredby'>Powered by MediaWiki $wgVersion</div>";
 31+ $text = "<div class='mw_poweredby'>Powered by MediaWiki $wgVersion</div>";
 32+ wfRunHooks( 'SkinGetPoweredBy', array( &$text ) );
 33+ return $text;
3234 }
3335
3436 function setupSkinUserCss( OutputPage $out ){
Index: trunk/phase3/docs/hooks.txt
@@ -1462,7 +1462,8 @@
14631463 &$forContent: overridable flag if copyright footer is shown in content language.
14641464
14651465 'SkinGetPoweredBy'
1466 -&$text: additional 'powered by' icons in HTML
 1466+&$text: additional 'powered by' icons in HTML.
 1467+Note: Modern skin does not use the MediaWiki icon but plain text instead
14671468
14681469 'SkinSubPageSubtitle': At the beginning of Skin::subPageSubtitle()
14691470 &$subpages: Subpage links HTML
Index: trunk/phase3/RELEASE-NOTES
@@ -201,7 +201,8 @@
202202 * Special:Search: Add CSS classes to 'none found' and 'create link' messages
203203 * Add CSS classes (including namespace and pagename) to the enhanced recent
204204 changes/watchlist entries
205 -* (bug 22463) Add hook 'SkinGetPoweredBy' to make 'powered by' icon customizable
 205+* (bug 22463) Add hook 'SkinGetPoweredBy' to make 'powered by' icon/text
 206+ customizable
206207 * Added CSS print pagination to the print stylesheets
207208
208209 === Bug fixes in 1.17 ===

Follow-up revisions

RevisionCommit summaryAuthorDate
r76668Follow-up r76434, r76570: Add skinname per CRraymond19:28, 14 November 2010
r76669Follow-up r76434, r76570,r76668: Pass skin object per CRraymond19:45, 14 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76434* (bug 22463) Add hook 'SkinGetPoweredBy' to make 'powered by' icon customizable...raymond08:18, 10 November 2010

Comments

#Comment by Platonides (talk | contribs)   18:55, 14 November 2010

It should be passed the Skin as parameter.

#Comment by Raymond (talk | contribs)   19:31, 14 November 2010

Added in r76668.

Status & tagging log