r76225 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r76224‎ | r76225 | r76226 >
Date:00:32, 7 November 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
Rm back-compat (was moved to the class in r36353) wfLoadAllExtensions(). Not used anywhere in core since message cache rewrite in 1.16. Can't find any uses in extensions in recent history.
Modified paths:
  • /trunk/phase3/includes/AutoLoader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/AutoLoader.php
——@@ -802,10 +802,6 @@
803803 }
804804 }
805805
806 -function wfLoadAllExtensions() {
807 - AutoLoader::loadAllExtensions();
808 -}
809 -
810806 if ( function_exists( 'spl_autoload_register' ) ) {
811807 spl_autoload_register( array( 'AutoLoader', 'autoload' ) );
812808 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r78376Per r76225 CR: Get rid of Autoloader::loadAllExtensions() "Anything that need...demon12:59, 14 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r36353* Reorganised the includes directory, creating subdirectories db, parser and ...tstarling20:21, 16 June 2008

Comments

#Comment by 😂 (talk | contribs)   00:33, 7 November 2010

Also, I can't find any users of AutoLoader::loadAllExtensions(). I didn't kill that because I wasn't sure if anyone still thought of it as useful.

#Comment by Catrope (talk | contribs)   13:18, 13 December 2010

I think AutoLoader::loadAllExtensions() can be killed. Anything that needs it is badly written and needs to use the AutoLoader properly.

Status & tagging log