r36353 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36352‎ | r36353 | r36354 >
Date:20:21, 16 June 2008
Author:tstarling
Status:old
Tags:
Comment:
* Reorganised the includes directory, creating subdirectories db, parser and specials
* Wrote a tool to check the integrity of the autoloader class list, fixed some issues that came up.
* Start the autoloader before LocalSettings.php, so that when an extension writer thinks an inefficient one-file special page extension is the way to go, they don't have to use explicit includes to make the class inheritance work. Should continue to work with $IP set in LocalSettings.php as long as $IP is set before extensions are included.
Modified paths:
  • /trunk/phase3/includes/AutoLoader.php (modified) (history)
  • /trunk/phase3/includes/CoreParserFunctions.php (deleted) (history)
  • /trunk/phase3/includes/Database.php (deleted) (history)
  • /trunk/phase3/includes/DatabaseMssql.php (deleted) (history)
  • /trunk/phase3/includes/DatabaseOracle.php (deleted) (history)
  • /trunk/phase3/includes/DatabasePostgres.php (deleted) (history)
  • /trunk/phase3/includes/DatabaseSqlite.php (deleted) (history)
  • /trunk/phase3/includes/DateFormatter.php (deleted) (history)
  • /trunk/phase3/includes/LBFactory.php (deleted) (history)
  • /trunk/phase3/includes/LBFactory_Multi.php (deleted) (history)
  • /trunk/phase3/includes/LoadBalancer.php (deleted) (history)
  • /trunk/phase3/includes/Parser.php (deleted) (history)
  • /trunk/phase3/includes/ParserCache.php (deleted) (history)
  • /trunk/phase3/includes/ParserOptions.php (deleted) (history)
  • /trunk/phase3/includes/ParserOutput.php (deleted) (history)
  • /trunk/phase3/includes/Parser_DiffTest.php (deleted) (history)
  • /trunk/phase3/includes/Parser_OldPP.php (deleted) (history)
  • /trunk/phase3/includes/Preprocessor.php (deleted) (history)
  • /trunk/phase3/includes/Preprocessor_DOM.php (deleted) (history)
  • /trunk/phase3/includes/Preprocessor_Hash.php (deleted) (history)
  • /trunk/phase3/includes/Setup.php (modified) (history)
  • /trunk/phase3/includes/SpecialAllmessages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialAllpages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialAncientpages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialBlockip.php (deleted) (history)
  • /trunk/phase3/includes/SpecialBlockme.php (deleted) (history)
  • /trunk/phase3/includes/SpecialBooksources.php (deleted) (history)
  • /trunk/phase3/includes/SpecialBrokenRedirects.php (deleted) (history)
  • /trunk/phase3/includes/SpecialCategories.php (deleted) (history)
  • /trunk/phase3/includes/SpecialConfirmemail.php (deleted) (history)
  • /trunk/phase3/includes/SpecialContributions.php (deleted) (history)
  • /trunk/phase3/includes/SpecialDeadendpages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialDisambiguations.php (deleted) (history)
  • /trunk/phase3/includes/SpecialDoubleRedirects.php (deleted) (history)
  • /trunk/phase3/includes/SpecialEmailuser.php (deleted) (history)
  • /trunk/phase3/includes/SpecialExport.php (deleted) (history)
  • /trunk/phase3/includes/SpecialFewestrevisions.php (deleted) (history)
  • /trunk/phase3/includes/SpecialFileDuplicateSearch.php (deleted) (history)
  • /trunk/phase3/includes/SpecialFilepath.php (deleted) (history)
  • /trunk/phase3/includes/SpecialImagelist.php (deleted) (history)
  • /trunk/phase3/includes/SpecialImport.php (deleted) (history)
  • /trunk/phase3/includes/SpecialIpblocklist.php (deleted) (history)
  • /trunk/phase3/includes/SpecialListgrouprights.php (deleted) (history)
  • /trunk/phase3/includes/SpecialListredirects.php (deleted) (history)
  • /trunk/phase3/includes/SpecialListusers.php (deleted) (history)
  • /trunk/phase3/includes/SpecialLockdb.php (deleted) (history)
  • /trunk/phase3/includes/SpecialLog.php (deleted) (history)
  • /trunk/phase3/includes/SpecialLonelypages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialLongpages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialMIMEsearch.php (deleted) (history)
  • /trunk/phase3/includes/SpecialMergeHistory.php (deleted) (history)
  • /trunk/phase3/includes/SpecialMissingFiles.php (deleted) (history)
  • /trunk/phase3/includes/SpecialMostcategories.php (deleted) (history)
  • /trunk/phase3/includes/SpecialMostimages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialMostlinked.php (deleted) (history)
  • /trunk/phase3/includes/SpecialMostlinkedcategories.php (deleted) (history)
  • /trunk/phase3/includes/SpecialMostlinkedtemplates.php (deleted) (history)
  • /trunk/phase3/includes/SpecialMostrevisions.php (deleted) (history)
  • /trunk/phase3/includes/SpecialMovepage.php (deleted) (history)
  • /trunk/phase3/includes/SpecialNewimages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialNewpages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)
  • /trunk/phase3/includes/SpecialPopularpages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialPreferences.php (deleted) (history)
  • /trunk/phase3/includes/SpecialPrefixindex.php (deleted) (history)
  • /trunk/phase3/includes/SpecialProtectedpages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialProtectedtitles.php (deleted) (history)
  • /trunk/phase3/includes/SpecialRandompage.php (deleted) (history)
  • /trunk/phase3/includes/SpecialRandomredirect.php (deleted) (history)
  • /trunk/phase3/includes/SpecialRecentchanges.php (deleted) (history)
  • /trunk/phase3/includes/SpecialRecentchangeslinked.php (deleted) (history)
  • /trunk/phase3/includes/SpecialResetpass.php (deleted) (history)
  • /trunk/phase3/includes/SpecialRevisiondelete.php (deleted) (history)
  • /trunk/phase3/includes/SpecialSearch.php (deleted) (history)
  • /trunk/phase3/includes/SpecialShortpages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialSpecialpages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialStatistics.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUncategorizedcategories.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUncategorizedimages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUncategorizedpages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUncategorizedtemplates.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUndelete.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUnlockdb.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUnusedcategories.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUnusedimages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUnusedtemplates.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUnwatchedpages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUpload.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUploadMogile.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUserlogin.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUserlogout.php (deleted) (history)
  • /trunk/phase3/includes/SpecialUserrights.php (deleted) (history)
  • /trunk/phase3/includes/SpecialVersion.php (deleted) (history)
  • /trunk/phase3/includes/SpecialWantedcategories.php (deleted) (history)
  • /trunk/phase3/includes/SpecialWantedpages.php (deleted) (history)
  • /trunk/phase3/includes/SpecialWatchlist.php (deleted) (history)
  • /trunk/phase3/includes/SpecialWhatlinkshere.php (deleted) (history)
  • /trunk/phase3/includes/SpecialWithoutinterwiki.php (deleted) (history)
  • /trunk/phase3/includes/WebStart.php (modified) (history)
  • /trunk/phase3/includes/db (added) (history)
  • /trunk/phase3/includes/db/Database.php (added) (history)
  • /trunk/phase3/includes/db/Database.php (added) (history)
  • /trunk/phase3/includes/db/DatabaseMssql.php (added) (history)
  • /trunk/phase3/includes/db/DatabaseMssql.php (added) (history)
  • /trunk/phase3/includes/db/DatabaseOracle.php (added) (history)
  • /trunk/phase3/includes/db/DatabaseOracle.php (added) (history)
  • /trunk/phase3/includes/db/DatabasePostgres.php (added) (history)
  • /trunk/phase3/includes/db/DatabasePostgres.php (added) (history)
  • /trunk/phase3/includes/db/DatabaseSqlite.php (added) (history)
  • /trunk/phase3/includes/db/DatabaseSqlite.php (added) (history)
  • /trunk/phase3/includes/db/LBFactory.php (added) (history)
  • /trunk/phase3/includes/db/LBFactory.php (added) (history)
  • /trunk/phase3/includes/db/LBFactory_Multi.php (added) (history)
  • /trunk/phase3/includes/db/LBFactory_Multi.php (added) (history)
  • /trunk/phase3/includes/db/LoadBalancer.php (added) (history)
  • /trunk/phase3/includes/db/LoadBalancer.php (added) (history)
  • /trunk/phase3/includes/parser (added) (history)
  • /trunk/phase3/includes/parser/CoreParserFunctions.php (added) (history)
  • /trunk/phase3/includes/parser/CoreParserFunctions.php (added) (history)
  • /trunk/phase3/includes/parser/DateFormatter.php (added) (history)
  • /trunk/phase3/includes/parser/DateFormatter.php (added) (history)
  • /trunk/phase3/includes/parser/Parser.php (added) (history)
  • /trunk/phase3/includes/parser/Parser.php (added) (history)
  • /trunk/phase3/includes/parser/ParserCache.php (added) (history)
  • /trunk/phase3/includes/parser/ParserCache.php (added) (history)
  • /trunk/phase3/includes/parser/ParserOptions.php (added) (history)
  • /trunk/phase3/includes/parser/ParserOptions.php (added) (history)
  • /trunk/phase3/includes/parser/ParserOutput.php (added) (history)
  • /trunk/phase3/includes/parser/ParserOutput.php (added) (history)
  • /trunk/phase3/includes/parser/Parser_DiffTest.php (added) (history)
  • /trunk/phase3/includes/parser/Parser_DiffTest.php (added) (history)
  • /trunk/phase3/includes/parser/Parser_OldPP.php (added) (history)
  • /trunk/phase3/includes/parser/Parser_OldPP.php (added) (history)
  • /trunk/phase3/includes/parser/Preprocessor.php (added) (history)
  • /trunk/phase3/includes/parser/Preprocessor.php (added) (history)
  • /trunk/phase3/includes/parser/Preprocessor_DOM.php (added) (history)
  • /trunk/phase3/includes/parser/Preprocessor_DOM.php (added) (history)
  • /trunk/phase3/includes/parser/Preprocessor_Hash.php (added) (history)
  • /trunk/phase3/includes/parser/Preprocessor_Hash.php (added) (history)
  • /trunk/phase3/includes/specials (added) (history)
  • /trunk/phase3/includes/specials/Allmessages.php (added) (history)
  • /trunk/phase3/includes/specials/Allmessages.php (added) (history)
  • /trunk/phase3/includes/specials/Allpages.php (added) (history)
  • /trunk/phase3/includes/specials/Allpages.php (added) (history)
  • /trunk/phase3/includes/specials/Ancientpages.php (added) (history)
  • /trunk/phase3/includes/specials/Ancientpages.php (added) (history)
  • /trunk/phase3/includes/specials/Blockip.php (added) (history)
  • /trunk/phase3/includes/specials/Blockip.php (added) (history)
  • /trunk/phase3/includes/specials/Blockme.php (added) (history)
  • /trunk/phase3/includes/specials/Blockme.php (added) (history)
  • /trunk/phase3/includes/specials/Booksources.php (added) (history)
  • /trunk/phase3/includes/specials/Booksources.php (added) (history)
  • /trunk/phase3/includes/specials/BrokenRedirects.php (added) (history)
  • /trunk/phase3/includes/specials/BrokenRedirects.php (added) (history)
  • /trunk/phase3/includes/specials/Categories.php (added) (history)
  • /trunk/phase3/includes/specials/Categories.php (added) (history)
  • /trunk/phase3/includes/specials/Confirmemail.php (added) (history)
  • /trunk/phase3/includes/specials/Confirmemail.php (added) (history)
  • /trunk/phase3/includes/specials/Contributions.php (added) (history)
  • /trunk/phase3/includes/specials/Contributions.php (added) (history)
  • /trunk/phase3/includes/specials/Deadendpages.php (added) (history)
  • /trunk/phase3/includes/specials/Deadendpages.php (added) (history)
  • /trunk/phase3/includes/specials/Disambiguations.php (added) (history)
  • /trunk/phase3/includes/specials/Disambiguations.php (added) (history)
  • /trunk/phase3/includes/specials/DoubleRedirects.php (added) (history)
  • /trunk/phase3/includes/specials/DoubleRedirects.php (added) (history)
  • /trunk/phase3/includes/specials/Emailuser.php (added) (history)
  • /trunk/phase3/includes/specials/Emailuser.php (added) (history)
  • /trunk/phase3/includes/specials/Export.php (added) (history)
  • /trunk/phase3/includes/specials/Export.php (added) (history)
  • /trunk/phase3/includes/specials/Fewestrevisions.php (added) (history)
  • /trunk/phase3/includes/specials/Fewestrevisions.php (added) (history)
  • /trunk/phase3/includes/specials/FileDuplicateSearch.php (added) (history)
  • /trunk/phase3/includes/specials/FileDuplicateSearch.php (added) (history)
  • /trunk/phase3/includes/specials/Filepath.php (added) (history)
  • /trunk/phase3/includes/specials/Filepath.php (added) (history)
  • /trunk/phase3/includes/specials/Imagelist.php (added) (history)
  • /trunk/phase3/includes/specials/Imagelist.php (added) (history)
  • /trunk/phase3/includes/specials/Import.php (added) (history)
  • /trunk/phase3/includes/specials/Import.php (added) (history)
  • /trunk/phase3/includes/specials/Ipblocklist.php (added) (history)
  • /trunk/phase3/includes/specials/Ipblocklist.php (added) (history)
  • /trunk/phase3/includes/specials/Listgrouprights.php (added) (history)
  • /trunk/phase3/includes/specials/Listgrouprights.php (added) (history)
  • /trunk/phase3/includes/specials/Listredirects.php (added) (history)
  • /trunk/phase3/includes/specials/Listredirects.php (added) (history)
  • /trunk/phase3/includes/specials/Listusers.php (added) (history)
  • /trunk/phase3/includes/specials/Listusers.php (added) (history)
  • /trunk/phase3/includes/specials/Lockdb.php (added) (history)
  • /trunk/phase3/includes/specials/Lockdb.php (added) (history)
  • /trunk/phase3/includes/specials/Log.php (added) (history)
  • /trunk/phase3/includes/specials/Log.php (added) (history)
  • /trunk/phase3/includes/specials/Lonelypages.php (added) (history)
  • /trunk/phase3/includes/specials/Lonelypages.php (added) (history)
  • /trunk/phase3/includes/specials/Longpages.php (added) (history)
  • /trunk/phase3/includes/specials/Longpages.php (added) (history)
  • /trunk/phase3/includes/specials/MIMEsearch.php (added) (history)
  • /trunk/phase3/includes/specials/MIMEsearch.php (added) (history)
  • /trunk/phase3/includes/specials/MergeHistory.php (added) (history)
  • /trunk/phase3/includes/specials/MergeHistory.php (added) (history)
  • /trunk/phase3/includes/specials/MissingFiles.php (added) (history)
  • /trunk/phase3/includes/specials/MissingFiles.php (added) (history)
  • /trunk/phase3/includes/specials/Mostcategories.php (added) (history)
  • /trunk/phase3/includes/specials/Mostcategories.php (added) (history)
  • /trunk/phase3/includes/specials/Mostimages.php (added) (history)
  • /trunk/phase3/includes/specials/Mostimages.php (added) (history)
  • /trunk/phase3/includes/specials/Mostlinked.php (added) (history)
  • /trunk/phase3/includes/specials/Mostlinked.php (added) (history)
  • /trunk/phase3/includes/specials/Mostlinkedcategories.php (added) (history)
  • /trunk/phase3/includes/specials/Mostlinkedcategories.php (added) (history)
  • /trunk/phase3/includes/specials/Mostlinkedtemplates.php (added) (history)
  • /trunk/phase3/includes/specials/Mostlinkedtemplates.php (added) (history)
  • /trunk/phase3/includes/specials/Mostrevisions.php (added) (history)
  • /trunk/phase3/includes/specials/Mostrevisions.php (added) (history)
  • /trunk/phase3/includes/specials/Movepage.php (added) (history)
  • /trunk/phase3/includes/specials/Movepage.php (added) (history)
  • /trunk/phase3/includes/specials/Newimages.php (added) (history)
  • /trunk/phase3/includes/specials/Newimages.php (added) (history)
  • /trunk/phase3/includes/specials/Newpages.php (added) (history)
  • /trunk/phase3/includes/specials/Newpages.php (added) (history)
  • /trunk/phase3/includes/specials/Popularpages.php (added) (history)
  • /trunk/phase3/includes/specials/Popularpages.php (added) (history)
  • /trunk/phase3/includes/specials/Preferences.php (added) (history)
  • /trunk/phase3/includes/specials/Preferences.php (added) (history)
  • /trunk/phase3/includes/specials/Prefixindex.php (added) (history)
  • /trunk/phase3/includes/specials/Prefixindex.php (added) (history)
  • /trunk/phase3/includes/specials/Protectedpages.php (added) (history)
  • /trunk/phase3/includes/specials/Protectedpages.php (added) (history)
  • /trunk/phase3/includes/specials/Protectedtitles.php (added) (history)
  • /trunk/phase3/includes/specials/Protectedtitles.php (added) (history)
  • /trunk/phase3/includes/specials/Randompage.php (added) (history)
  • /trunk/phase3/includes/specials/Randompage.php (added) (history)
  • /trunk/phase3/includes/specials/Randomredirect.php (added) (history)
  • /trunk/phase3/includes/specials/Randomredirect.php (added) (history)
  • /trunk/phase3/includes/specials/Recentchanges.php (added) (history)
  • /trunk/phase3/includes/specials/Recentchanges.php (added) (history)
  • /trunk/phase3/includes/specials/Recentchangeslinked.php (added) (history)
  • /trunk/phase3/includes/specials/Recentchangeslinked.php (added) (history)
  • /trunk/phase3/includes/specials/Resetpass.php (added) (history)
  • /trunk/phase3/includes/specials/Resetpass.php (added) (history)
  • /trunk/phase3/includes/specials/Revisiondelete.php (added) (history)
  • /trunk/phase3/includes/specials/Revisiondelete.php (added) (history)
  • /trunk/phase3/includes/specials/Search.php (added) (history)
  • /trunk/phase3/includes/specials/Search.php (added) (history)
  • /trunk/phase3/includes/specials/Shortpages.php (added) (history)
  • /trunk/phase3/includes/specials/Shortpages.php (added) (history)
  • /trunk/phase3/includes/specials/Specialpages.php (added) (history)
  • /trunk/phase3/includes/specials/Specialpages.php (added) (history)
  • /trunk/phase3/includes/specials/Statistics.php (added) (history)
  • /trunk/phase3/includes/specials/Statistics.php (added) (history)
  • /trunk/phase3/includes/specials/Uncategorizedcategories.php (added) (history)
  • /trunk/phase3/includes/specials/Uncategorizedcategories.php (added) (history)
  • /trunk/phase3/includes/specials/Uncategorizedimages.php (added) (history)
  • /trunk/phase3/includes/specials/Uncategorizedimages.php (added) (history)
  • /trunk/phase3/includes/specials/Uncategorizedpages.php (added) (history)
  • /trunk/phase3/includes/specials/Uncategorizedpages.php (added) (history)
  • /trunk/phase3/includes/specials/Uncategorizedtemplates.php (added) (history)
  • /trunk/phase3/includes/specials/Uncategorizedtemplates.php (added) (history)
  • /trunk/phase3/includes/specials/Undelete.php (added) (history)
  • /trunk/phase3/includes/specials/Undelete.php (added) (history)
  • /trunk/phase3/includes/specials/Unlockdb.php (added) (history)
  • /trunk/phase3/includes/specials/Unlockdb.php (added) (history)
  • /trunk/phase3/includes/specials/Unusedcategories.php (added) (history)
  • /trunk/phase3/includes/specials/Unusedcategories.php (added) (history)
  • /trunk/phase3/includes/specials/Unusedimages.php (added) (history)
  • /trunk/phase3/includes/specials/Unusedimages.php (added) (history)
  • /trunk/phase3/includes/specials/Unusedtemplates.php (added) (history)
  • /trunk/phase3/includes/specials/Unusedtemplates.php (added) (history)
  • /trunk/phase3/includes/specials/Unwatchedpages.php (added) (history)
  • /trunk/phase3/includes/specials/Unwatchedpages.php (added) (history)
  • /trunk/phase3/includes/specials/Upload.php (added) (history)
  • /trunk/phase3/includes/specials/Upload.php (added) (history)
  • /trunk/phase3/includes/specials/UploadMogile.php (added) (history)
  • /trunk/phase3/includes/specials/UploadMogile.php (added) (history)
  • /trunk/phase3/includes/specials/Userlogin.php (added) (history)
  • /trunk/phase3/includes/specials/Userlogin.php (added) (history)
  • /trunk/phase3/includes/specials/Userlogout.php (added) (history)
  • /trunk/phase3/includes/specials/Userlogout.php (added) (history)
  • /trunk/phase3/includes/specials/Userrights.php (added) (history)
  • /trunk/phase3/includes/specials/Userrights.php (added) (history)
  • /trunk/phase3/includes/specials/Version.php (added) (history)
  • /trunk/phase3/includes/specials/Version.php (added) (history)
  • /trunk/phase3/includes/specials/Wantedcategories.php (added) (history)
  • /trunk/phase3/includes/specials/Wantedcategories.php (added) (history)
  • /trunk/phase3/includes/specials/Wantedpages.php (added) (history)
  • /trunk/phase3/includes/specials/Wantedpages.php (added) (history)
  • /trunk/phase3/includes/specials/Watchlist.php (added) (history)
  • /trunk/phase3/includes/specials/Watchlist.php (added) (history)
  • /trunk/phase3/includes/specials/Whatlinkshere.php (added) (history)
  • /trunk/phase3/includes/specials/Whatlinkshere.php (added) (history)
  • /trunk/phase3/includes/specials/Withoutinterwiki.php (added) (history)
  • /trunk/phase3/includes/specials/Withoutinterwiki.php (added) (history)
  • /trunk/phase3/includes/templates/Userlogin.php (modified) (history)
  • /trunk/phase3/maintenance/checkAutoLoader.php (added) (history)
  • /trunk/phase3/maintenance/commandLine.inc (modified) (history)

Follow-up revisions

RevisionCommit summaryAuthorDate
r36354Fixes for special page reorganisation in r36353.tstarling20:23, 16 June 2008
r76225Rm back-compat (was moved to the class in r36353) wfLoadAllExtensions(). Not ...demon00:32, 7 November 2010

Status & tagging log