r76182 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r76181‎ | r76182 | r76183 >
Date:08:25, 6 November 2010
Author:neilk
Status:deferred (Comments)
Tags:
Comment:
reasonable optimization & minification for resources without ResourceLoader
Modified paths:
  • /trunk/extensions/UploadWizard/SpecialUploadWizard.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizard.i18n.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizard.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizardDependencyLoader.php (added) (history)
  • /trunk/extensions/UploadWizard/UploadWizardHooks.php (modified) (history)
  • /trunk/extensions/UploadWizard/combined.css (added) (history)
  • /trunk/extensions/UploadWizard/combined.js (added) (history)
  • /trunk/extensions/UploadWizard/combined.min.css (added) (history)
  • /trunk/extensions/UploadWizard/combined.min.js (added) (history)
  • /trunk/extensions/UploadWizard/generateMinifiedResources.php (added) (history)
  • /trunk/extensions/UploadWizard/resources/combined.css (added) (history)
  • /trunk/extensions/UploadWizard/resources/combined.js (added) (history)
  • /trunk/extensions/UploadWizard/resources/combined.min.css (added) (history)
  • /trunk/extensions/UploadWizard/resources/combined.min.js (added) (history)
  • /trunk/extensions/UploadWizard/resources/dir.combined.css (added) (history)
  • /trunk/extensions/UploadWizard/resources/dir.combined.min.css (added) (history)
  • /trunk/extensions/UploadWizard/resources/jquery.ui/themes/redmond/combined.min.js (added) (history)
  • /trunk/extensions/UploadWizard/resources/jquery.ui/themes/redmond/dir.combined.css (added) (history)
  • /trunk/extensions/UploadWizard/resources/jquery.ui/themes/redmond/dir.combined.min.css (added) (history)
  • /trunk/extensions/UploadWizard/resources/jquery/dir.combined.css (added) (history)
  • /trunk/extensions/UploadWizard/resources/jquery/dir.combined.min.css (added) (history)
  • /trunk/extensions/UploadWizard/resources/uploadWizard.css (modified) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

RevisionCommit summaryAuthorDate
r76188Followup r76182: remove unused combined.* files in the top directorycatrope12:35, 6 November 2010
r76189Fix r76182 in various ways. Also addresses CR on r75954...catrope13:10, 6 November 2010
r76193Fix ResourceLoader support in UploadWizard, which was broken by r76182, possi...catrope15:13, 6 November 2010

Comments

#Comment by Mormegil (talk | contribs)   21:11, 7 November 2010

I guess the trailing dot at the selector of 

.mwe-upwiz-details-filename. {
        overflow: hidden;
        width: 350px;
}

in dir.combined[.min].css is an unwanted typo, not some dark browser-compatibility magic.

#Comment by NeilK (talk | contribs)   19:47, 15 November 2010

Good catch, fixed in r76697

#Comment by Mormegil (talk | contribs)   22:08, 17 November 2010

$module['languageScripts'][$langCode] is added incorrectly at [1], it contains a filename (e.g. resources/languages/classes/LanguageCs.js), but is added verbatim to HTML output as an inline script. See the HTML code of [2].

Status & tagging log