r75954 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r75953‎ | r75954 | r75955 >
Date:19:47, 3 November 2010
Author:neilk
Status:resolved (Comments)
Tags:
Comment:
fix css urls to use scriptPath
Modified paths:
  • /trunk/extensions/UploadWizard/SpecialUploadWizard.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/SpecialUploadWizard.php
——@@ -87,7 +87,7 @@
8888
8989 // TODO RTL
9090 foreach ( $module['styles'] as $style ) {
91 - $wgOut->addStyle( "/" . $style, '', '', 'ltr' );
 91+ $wgOut->addStyle( $wgScriptPath . "/" . $style, '', '', 'ltr' );
9292 }
9393
9494 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r76189Fix r76182 in various ways. Also addresses CR on r75954...catrope13:10, 6 November 2010

Comments

#Comment by Catrope (talk | contribs)   12:01, 4 November 2010

This is wrong, and needs a little refactoring. You have to use $wgExtensionAssetsPath, which on the WMF cluster points to http://bits.wikimedia.org/w/extensions (and generally points to the extensions dir), which means that the extensions/ part of the paths in UploadWizardHooks.php has to be removed (fortunately, ResourceLoaderFileModule has basepath parameters to handle that).

#Comment by Catrope (talk | contribs)   13:11, 6 November 2010

I did that in r76189.

Status & tagging log