r76129 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r76128‎ \| r76129 \| r76130 >
Date:	19:39, 5 November 2010
Author:	mah
Status:	reverted
Tags:
Comment:	followup r76127 - update parser tests.
Modified paths:	/trunk/phase3/maintenance/tests/parser/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/parser/parserTests.txt
—	—	@@ -1388,7 +1388,7 @@
1389	1389	!! input
1390	1390	[[Main Page]]
1391	1391	!! result
1392		~~-<p><a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a>~~
	1392	+<p><a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a>
1393	1393	</p>
1394	1394	!! end
1395	1395
—	—	@@ -1397,7 +1397,7 @@
1398	1398	!! input
1399	1399	[[main Page]]
1400	1400	!! result
1401		~~-<p><a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">main Page</a>~~
	1401	+<p><a href="https://www.mediawiki.org/wiki/Main_Page">main Page</a>
1402	1402	</p>
1403	1403	!! end
1404	1404
—	—	@@ -1451,7 +1451,7 @@
1452	1452	!! input
1453	1453	xxx[[main Page]], xxx[[Main Page]], Xxx[[main Page]] XXX[[main Page]], XXX[[Main Page]]
1454	1454	!! result
1455		-<p>xxx<a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">main Page</a>, xxx<a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a>, Xxx<a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">main Page</a> XXX<a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">main Page</a>, XXX<a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a>
	1455	+<p>xxx<a href="https://www.mediawiki.org/wiki/Main_Page">main Page</a>, xxx<a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a>, Xxx<a href="https://www.mediawiki.org/wiki/Main_Page">main Page</a> XXX<a href="https://www.mediawiki.org/wiki/Main_Page">main Page</a>, XXX<a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a>
1456	1456	</p>
1457	1457	!! end
1458	1458
—	—	@@ -1460,7 +1460,7 @@
1461	1461	!! input
1462	1462	[[Main Page]]xxx, [[Main Page]]XXX, [[Main Page]]!!!
1463	1463	!! result
1464		-<p><a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Pagexxx</a>, <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a>XXX, <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a>!!!
	1464	+<p><a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Pagexxx</a>, <a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a>XXX, <a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a>!!!
1465	1465	</p>
1466	1466	!! end
1467	1467
—	—	@@ -1693,7 +1693,7 @@
1694	1694	!!input
1695	1695	[[00]]
1696	1696	!!result
1697		~~-<p><a href="https://www.mediawiki.org/wiki/00" title="00">00</a>~~
	1697	+<p><a href="https://www.mediawiki.org/wiki/00">00</a>
1698	1698	</p>
1699	1699	!!end
1700	1700
—	—	@@ -1725,7 +1725,7 @@
1726	1726	!! input
1727	1727	[[MeatBall:SoftSecurity]]
1728	1728	!! result
1729		~~-<p><a href="http://www.usemod.com/cgi-bin/mb.pl?SoftSecurity" class="extiw" title="meatball:SoftSecurity">MeatBall:SoftSecurity</a>~~
	1729	+<p><a href="http://www.usemod.com/cgi-bin/mb.pl?SoftSecurity" class="extiw">MeatBall:SoftSecurity</a>
1730	1730	</p>
1731	1731	!! end
1732	1732
—	—	@@ -1734,7 +1734,7 @@
1735	1735	!! input
1736	1736	[[MeatBall:]]
1737	1737	!! result
1738		~~-<p><a href="http://www.usemod.com/cgi-bin/mb.pl?" class="extiw" title="meatball:">MeatBall:</a>~~
	1738	+<p><a href="http://www.usemod.com/cgi-bin/mb.pl?" class="extiw">MeatBall:</a>
1739	1739	</p>
1740	1740	!! end
1741	1741
—	—	@@ -2608,7 +2608,7 @@
2609	2609	!! input
2610	2610	[[{{linktest2}}]]
2611	2611	!! result
2612		~~-<p><a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a>~~
	2612	+<p><a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a>
2613	2613	</p>
2614	2614	!! end
2615	2615
—	—	@@ -2630,7 +2630,7 @@
2631	2631	!! input
2632	2632	{{loop1}}
2633	2633	!! result
2634		~~-<p><span class="error">Template loop detected: <a href="https://www.mediawiki.org/wiki/Template:Loop1" title="Template:Loop1">Template:Loop1</a></span>~~
	2634	+<p><span class="error">Template loop detected: <a href="https://www.mediawiki.org/wiki/Template:Loop1">Template:Loop1</a></span>
2635	2635	</p>
2636	2636	!! end
2637	2637
—	—	@@ -3402,7 +3402,7 @@
3403	3403	!! input
3404	3404	[[Image:Foobar.jpg\|frame\|left\|This is a test image [[Main Page]]]]
3405	3405	!! result
3406		-<div class="thumb tleft"><div class="thumbinner" style="width:1943px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" class="thumbimage" /></a> <div class="thumbcaption">This is a test image <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a></div></div></div>
	3406	+<div class="thumb tleft"><div class="thumbinner" style="width:1943px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" class="thumbimage" /></a> <div class="thumbcaption">This is a test image <a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a></div></div></div>
3407	3407
3408	3408	!! end
3409	3409
—	—	@@ -3411,7 +3411,7 @@
3412	3412	!! input
3413	3413	[[Image:Foobar.jpg\|frame\|left\|This is a test image [[Main Page]]\|alt=Altitude]]
3414	3414	!! result
3415		-<div class="thumb tleft"><div class="thumbinner" style="width:1943px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="Altitude" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" class="thumbimage" /></a> <div class="thumbcaption">This is a test image <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a></div></div></div>
	3415	+<div class="thumb tleft"><div class="thumbinner" style="width:1943px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="Altitude" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" class="thumbimage" /></a> <div class="thumbcaption">This is a test image <a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a></div></div></div>
3416	3416
3417	3417	!! end
3418	3418
—	—	@@ -3632,7 +3632,7 @@
3633	3633	!! input
3634	3634	[[Image:Barfoo.jpg]]
3635	3635	!! result
3636		~~-<p><a href="https://www.mediawiki.org/wiki/File:Barfoo.jpg" title="File:Barfoo.jpg">File:Barfoo.jpg</a>~~
	3636	+<p><a href="https://www.mediawiki.org/wiki/File:Barfoo.jpg">File:Barfoo.jpg</a>
3637	3637	</p>
3638	3638	!! end
3639	3639
—	—	@@ -3643,7 +3643,7 @@
3644	3644	!! input
3645	3645	[[Image:Foobaz.jpg]]
3646	3646	!! result
3647		~~-<p><a href="https://www.mediawiki.org/wiki/File:Foobaz.jpg" title="File:Foobaz.jpg">File:Foobaz.jpg</a>~~
	3647	+<p><a href="https://www.mediawiki.org/wiki/File:Foobaz.jpg">File:Foobaz.jpg</a>
3648	3648	</p>
3649	3649	!! end
3650	3650
—	—	@@ -3713,7 +3713,7 @@
3714	3714	!! input
3715	3715	[[:Category:MediaWiki User's Guide]]
3716	3716	!! result
3717		~~-<p><a href="https://www.mediawiki.org/wiki/Category:MediaWiki_User%27s_Guide" title="Category:MediaWiki User's Guide">Category:MediaWiki User's Guide</a>~~
	3717	+<p><a href="https://www.mediawiki.org/wiki/Category:MediaWiki_User%27s_Guide">Category:MediaWiki User's Guide</a>
3718	3718	</p>
3719	3719	!! end
3720	3720
—	—	@@ -4381,7 +4381,7 @@
4382	4382	<a href="https://www.mediawiki.org/wiki/%D7%90%D6%B7" title="אַ">אַ</a>
4383	4383	<a href="https://www.mediawiki.org/wiki/%D7%90%D6%B7" title="אַ">אַ</a>
4384	4384	<a href="https://www.mediawiki.org/wiki/%D7%90%D6%B7" title="אַ">אַ</a>
4385		~~-<a href="https://www.mediawiki.org/wiki/%D7%90%D6%B7" title="אַ">אַ</a>~~
	4385	+<a href="https://www.mediawiki.org/wiki/%D7%90%D6%B7">אַ</a>
4386	4386	</p>
4387	4387	!! end
4388	4388
—	—	@@ -4444,7 +4444,7 @@
4445	4445	!! input
4446	4446	[[Main Page]]]
4447	4447	!! result
4448		~~-<p><a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a>]~~
	4448	+<p><a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a>]
4449	4449	</p>
4450	4450	!! end
4451	4451
—	—	@@ -5635,7 +5635,7 @@
5636	5636	!! result
5637	5637	<p><br />
5638	5638	</p>
5639		~~-<table border="0" id="mw-prefixindex-list-table"><tr><td><a href="https://www.mediawiki.org/wiki/Xyzzyx" title="Xyzzyx">Xyzzyx</a></td></tr></table>~~
	5639	+<table border="0" id="mw-prefixindex-list-table"><tr><td><a href="https://www.mediawiki.org/wiki/Xyzzyx">Xyzzyx</a></td></tr></table>
5640	5640
5641	5641	!! end
5642	5642
—	—	@@ -5648,10 +5648,10 @@
5649	5649	!! result
5650	5650	<p><br />
5651	5651	</p>
5652		~~-<table border="0" id="mw-prefixindex-list-table"><tr><td><a href="https://www.mediawiki.org/wiki/Xyzzyx" title="Xyzzyx">Xyzzyx</a></td></tr></table>~~
	5652	+<table border="0" id="mw-prefixindex-list-table"><tr><td><a href="https://www.mediawiki.org/wiki/Xyzzyx">Xyzzyx</a></td></tr></table>
5653	5653	<p><br />
5654	5654	</p>
5655		~~-<table border="0" id="mw-prefixindex-list-table"><tr><td><a href="https://www.mediawiki.org/wiki/Xyzzyx" title="Xyzzyx">Xyzzyx</a></td></tr></table>~~
	5655	+<table border="0" id="mw-prefixindex-list-table"><tr><td><a href="https://www.mediawiki.org/wiki/Xyzzyx">Xyzzyx</a></td></tr></table>
5656	5656
5657	5657	!! end
5658	5658
—	—	@@ -6546,7 +6546,7 @@
6547	6547	!! input
6548	6548	{{Special:search}}
6549	6549	!! result
6550		~~-<p><a href="https://www.mediawiki.org/wiki/Special:Search" title="Special:Search">Special:Search</a>~~
	6550	+<p><a href="https://www.mediawiki.org/wiki/Special:Search">Special:Search</a>
6551	6551	</p>
6552	6552	!! end
6553	6553
—	—	@@ -6663,7 +6663,7 @@
6664	6664	</gallery>
6665	6665	!! result
6666	6666	<table class="gallery" cellspacing="0" cellpadding="0">
6667		~~- <caption>Foo <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a></caption>~~
	6667	+ <caption>Foo <a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a></caption>
6668	6668	<tr>
6669	6669	<td><div class="gallerybox" style="width: 95px;">
6670	6670	<div style="height: 52px;">Nonexistant.jpg</div>
—	—	@@ -6682,7 +6682,7 @@
6683	6683	<td><div class="gallerybox" style="width: 95px;">
6684	6684	<div class="thumb" style="padding: 19px 0; width: 90px;"><div style="margin-left: auto; margin-right: auto; width: 60px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="60" height="7" /></a></div></div>
6685	6685	<div class="gallerytext">
6686		~~-<p>some <b>caption</b> <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a>~~
	6686	+<p>some <b>caption</b> <a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a>
6687	6687	</p>
6688	6688	</div>
6689	6689	</div></td>
—	—	@@ -6727,7 +6727,7 @@
6728	6728	<div class="thumb" style="padding: 66px 0; width: 150px;"><div style="margin-left: auto; margin-right: auto; width: 120px;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="120" height="14" /></a></div></div>
6729	6729	<div class="gallerytext">
6730	6730	<p><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" title="File:Foobar.jpg">Foobar.jpg</a><br />
6731		~~-some <b>caption</b> <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a>~~
	6731	+some <b>caption</b> <a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a>
6732	6732	</p>
6733	6733	</div>
6734	6734	</div></td>
—	—	@@ -7301,7 +7301,7 @@
7302	7302	!! input
7303	7303	[[Main Page]] can be written as [[Маин Паге]] same as [[Маин Паге]].
7304	7304	!! result
7305		-<p><a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a> can be written as <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Маин Паге</a> same as <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Маин Паге</a>.
	7305	+<p><a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a> can be written as <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Маин Паге</a> same as <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Маин Паге</a>.
7306	7306	</p>
7307	7307	!!end
7308	7308
—	—	@@ -7396,7 +7396,7 @@
7397	7397	!! input
7398	7398	-{[[Main Page]]}-
7399	7399	!! result
7400		~~-<p><a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a>~~
	7400	+<p><a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a>
7401	7401	</p>
7402	7402	!! end
7403	7403
—	—	@@ -7898,9 +7898,9 @@
7899	7899	[[meatball:2]]
7900	7900	[[meatball:3]]
7901	7901	!! result
7902		~~-<p><a href="http://www.usemod.com/cgi-bin/mb.pl?1" class="extiw" title="meatball:1">meatball:1</a>~~
7903		~~-<a href="http://www.usemod.com/cgi-bin/mb.pl?2" class="extiw" title="meatball:2">meatball:2</a>~~
7904		~~-<a href="http://www.usemod.com/cgi-bin/mb.pl?3" class="extiw" title="meatball:3">meatball:3</a>~~
	7902	+<p><a href="http://www.usemod.com/cgi-bin/mb.pl?1" class="extiw">meatball:1</a>
	7903	+<a href="http://www.usemod.com/cgi-bin/mb.pl?2" class="extiw">meatball:2</a>
	7904	+<a href="http://www.usemod.com/cgi-bin/mb.pl?3" class="extiw">meatball:3</a>
7905	7905	</p>
7906	7906	!! end
7907	7907
—	—	@@ -8017,7 +8017,7 @@
8018	8018	!! input
8019	8019	I like the [[Main Page]] a lot
8020	8020	!! result
8021		~~-I like the <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a> a lot~~
	8021	+I like the <a href="https://www.mediawiki.org/wiki/Main_Page">Main Page</a> a lot
8022	8022	!!end
8023	8023
8024	8024	!! test

Follow-up revisions

Revision	Commit summary	Author	Date
r87030	revert r76127, r76129, and r83535 b/c I'm backing out the fix for bug #542. ...	mah	19:13, 27 April 2011

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r76127	Resolves Bug#542 by removing the link title from in-wiki links where...	mah	19:06, 5 November 2010

Status & tagging log

20:46, 12 July 2011 😂 (talk | contribs) changed the status of r76129 [removed: ok added: reverted]
20:04, 5 November 2010 Platonides (talk | contribs) changed the status of r76129 [removed: new added: ok]