r76130 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76129‎ | r76130 | r76131 >
Date:19:40, 5 November 2010
Author:platonides
Status:deferred
Tags:
Comment:
We have debug_print_backtrace() in PHP 5. Do not try to recreate it.
Modified paths:
  • /trunk/phase3/maintenance/tests/parser/parserTest.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/parser/parserTest.inc
@@ -1162,7 +1162,8 @@
11631163 $oldCapitalLinks = $wgCapitalLinks;
11641164 $wgCapitalLinks = true; // We only need this from SetupGlobals() See r70917#c8637
11651165
1166 - $title = Title::newFromText( self::chomp($name) );
 1166+ $name = self::chomp( $name );
 1167+ $title = Title::newFromText( $name );
11671168
11681169 if ( is_null( $title ) ) {
11691170 wfDie( "invalid title ('$name' => '$title') at line $line\n" );
@@ -1171,9 +1172,7 @@
11721173 $aid = $title->getArticleID( Title::GAID_FOR_UPDATE );
11731174
11741175 if ( $aid != 0 ) {
1175 - foreach(debug_backtrace() as $bt) {
1176 - echo "{$bt['file']}::{$bt['line']}\n";
1177 - }
 1176+ debug_print_backtrace();
11781177 wfDie( "duplicate article '$name' at line $line\n" );
11791178 }
11801179

Status & tagging log