r76005 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76004‎ | r76005 | r76006 >
Date:14:13, 4 November 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
Followup r75976, remove hardcoded spaces, CSS handles it. Also escape input
Modified paths:
  • /trunk/extensions/CodeReview/ui/WordCloud.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/WordCloud.php
@@ -92,7 +92,8 @@
9393 * Default text callback for word display
9494 */
9595 public function defaultTextCallback( $word, $sizeRange ) {
96 - return "<span class=\"mw-wordcloud-size-$sizeRange\"> &nbsp; {$word} &nbsp; </span>";
 96+ return Html::element( 'span', array(
 97+ 'class' => 'mw-wordcloud-size-' . $sizeRange ), $word );
9798 }
9899
99100 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75976bug 24132, apply documentation updates to dumpBackup.php...reedy02:04, 4 November 2010

Comments

#Comment by 😂 (talk | contribs)   14:14, 4 November 2010

And by that I totally meant r76001.

Status & tagging log