r75832 MediaWiki - Code Review archive

It appears my i18n changes got conflicted into oblivion.

That's not all that got conflicted, this revision contains many unrelated changes, for instance

-		return $this->getTextBox( 'wgSQLiteDataDir', 'config-sqlite-dir' ) .
-			$this->parent->getHelpBox( 'config-sqlite-dir-help' ) .
-			$this->getTextBox( 'wgDBname', 'config-db-name' ) .
-			$this->parent->getHelpBox( 'config-sqlite-name-help' );
+		return $this->getTextBox( 'wgSQLiteDataDir', 'config-sqlite-dir', array(), $this->parent->getHelpBox( 'config-sqlite-dir-help' ) ) .
+			$this->getTextBox( 'wgDBname', 'config-db-name', array(), $this->parent->getHelpBox( 'config-sqlite-name-help' ) );

and probably lots more. I'm not too familiar with the new installer, so someone who is should examine the diff carefully.

That change was listed ("Modified several of the installer's widget display methods") - but that could possibly have been clearer.

Some of the widgets are defined multiple times with differing method signatures. I needed to move the "helpboxes" inside of the display methods across the board and in some cases the only way to do this was to add them as the last argument (which necessitated supplying an empty array() in some places, as shown in the example you pasted).

So it is, I missed that.

There were whitespace-only changes on some lines, please try to avoid mixing them with other changes.

At first glance, this looks ok. Need to svn up and check though. One thing does stand out:

+	background: #EEEEEE;

Was this intentional, or left over from testing?

It's intentional but it's part of a longer-term visual shift. I'm not done with it but I wanted to get this landed to avoid further conflicts.

Ok :)

I see typsy was added as a plugin. Is there a reason not to use jQuery UI's tooltip ability ?

Some help messages (ex.: config-sqlite-dir-help contain formatting, for example <code>. They're broken by this rev, as HTML tags are escaped in tooltips.

Some minor nitpicking:

• Question mark in a square looks slightly like checkbox. Proably, it could be enlarged a bit to reduce confusion?
• Help messages are now impossible to copy+paste, which could be needed for support requests aka "but your installer said this and that".

I don't like them. Can we have the old help boxes back?

On the DBSettings page, they go off the left margin, so you can only read the second half of each line. The HTML formatting has gone away, meaning that we lose lots of formatting and links. In fact, proper HTML escaping is missing:

		//$html = $this->parse( $text, true );
    $html = $text;
		return
            "<span class=\"mw-help-field-hint\"\n" .
      	    "     title=\"" . $html . "\"\n" .
    	    "     original-title=\"" . $html . "\"></span>\n";

meaning that many pages are generating invalid HTML, since many of the messages have double quotes in them. There may even be XSS. The behaviour when JS is disabled is bad, the trigger on hover instead of mouseover is non-obvious, and some browsers won't display such a long tooltip. And I know that alpha/opacity is the latest cool thing in web design, but it makes foreground text harder to read when you have a low-contrast version of some other text in the background.

But the main problem, I think, is that tooltips are the wrong kind of display element to use when you want to show a large amount of text. They obscure what is underneath them, you can't select text in them or copy from them. You could make them stay up for a bit longer to enable things like text selection and links, but then the complaint would be that they randomly disappear when you're just about to do something with them.

Re-marking reverted (because it was).

It was re-added in r77898 and had fixes in r77929, so those should be the points of review now.