r75698 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r75697‎ | r75698 | r75699 >
Date:17:20, 30 October 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
Oracle maintainer should enable E_STRICT ;-)
Modified paths:
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
——@@ -971,7 +971,7 @@
972972 }
973973
974974 /* defines must comply with ^define\s*([^\s=]*)\s*=\s?'\{\$([^\}]*)\}'; */
975 - function sourceStream( $fp, $lineCallback = false, $resultCallback = false ) {
 975+ function sourceStream( $fp, $lineCallback = false, $resultCallback = false, $fname = 'DatabaseOracle::sourceStream' ) {
976976 $cmd = '';
977977 $done = false;
978978 $dollarquote = false;

Comments

#Comment by Reedy (talk | contribs)   19:41, 30 October 2010

Oracle sucks! :D

#Comment by Freakolowsky (talk | contribs)   19:03, 31 October 2010

Oracle maintainer will enable E_STRICT.

@Reedy: MySQL is part of Oracle ... *hint* *hint*

Status & tagging log