r75697 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75696‎ | r75697 | r75698 >
Date:17:17, 30 October 2010
Author:demon
Status:ok
Tags:
Comment:
E_STRICT: Function signature should match parent. This newFromParams stuff should be going away soon anyway
Modified paths:
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -219,9 +219,9 @@
220220 return true;
221221 }
222222
223 - static function newFromParams( $server, $user, $password, $dbName, $flags = 0, $tablePrefix )
 223+ static function newFromParams( $server, $user, $password, $dbName, $flags = 0 )
224224 {
225 - return new DatabaseOracle( $server, $user, $password, $dbName, $flags, $tablePrefix );
 225+ return new DatabaseOracle( $server, $user, $password, $dbName, $flags );
226226 }
227227
228228 /**

Status & tagging log