r75662 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75661‎ | r75662 | r75663 >
Date:18:52, 29 October 2010
Author:hartman
Status:ok (Comments)
Tags:
Comment:
Switch the hyphen in diff output to actually minus signs.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/diff/DifferenceEngine.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceEngine.php
@@ -1172,7 +1172,7 @@
11731173
11741174 # HTML-escape parameter before calling this
11751175 function deletedLine( $line ) {
1176 - return $this->wrapLine( '-', 'diff-deletedline', $line );
 1176+ return $this->wrapLine( '−', 'diff-deletedline', $line );
11771177 }
11781178
11791179 # HTML-escape parameter before calling this
Index: trunk/phase3/RELEASE-NOTES
@@ -374,6 +374,7 @@
375375 requested.
376376 * (bug 22308) Search now finds text in default main page immediately after setup
377377 * (bug 25697) Make sure empty lines render in diff view.
 378+* Use an actual minus sign in diff views, instead of a hyphen.
378379
379380 === API changes in 1.17 ===
380381 * (bug 22738) Allow filtering by action type on query=logevent.
@@ -462,6 +463,8 @@
463464 <head> and by providing an API module action=rsd. Added hook
464465 ApiRsdServiceApis for extensions to add their own service to the services
465466 list.
 467+* The HTML of diff output markers has changed. Hyphens are now minus signs,
 468+ empty markers are now filled with non-breaking-space characters.
466469
467470 === Languages updated in 1.17 ===
468471

Follow-up revisions

RevisionCommit summaryAuthorDate
r80196Follow up r75662 and r67090 — use UTF-8 minus instead of HTML entitymah22:09, 13 January 2011

Comments

#Comment by Happy-melon (talk | contribs)   23:24, 14 December 2010

Wasn't there something recently about HTMl named character references breaking XML well-formedness?

#Comment by MarkAHershberger (talk | contribs)   19:34, 13 January 2011

And they do, but that is beside the point since the wiki produces HTML 5

#Comment by MarkAHershberger (talk | contribs)   19:40, 13 January 2011

Out of curiosity, why not change   (right after this) to   Or, instead of −, use − ??

#Comment by MarkAHershberger (talk | contribs)   19:42, 13 January 2011

argh, should be:

Out of curiosity, why not change &#160; (right after this) to &nbsp; Or, instead of &minus; use &#8722; ??

#Comment by Nikerabbit (talk | contribs)   19:47, 13 January 2011

See r66254.

#Comment by Happy-melon (talk | contribs)   20:10, 13 January 2011

You mean r67090...

#Comment by MarkAHershberger (talk | contribs)   21:53, 13 January 2011

Then, this should be − instead of &minus;

Status & tagging log