r66254 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66253‎ | r66254 | r66255 >
Date:02:09, 12 May 2010
Author:simetrical
Status:reverted (Comments)
Tags:
Comment:
Remove most named character references from output

This was basically just

find -iname '*.php' -exec sed -i 's/ /\ /g;s/—/―/g;s/•/•/g;s/á/á/g;s/´/´/g;s/à/à/g;s/ä/ä/g;s/©/©/g;s/↓/↓/g;s/°/°/g;s/é/é/g;s/è/è/g;s/€/€/g;s/…/…/g;s/í/í/g;s/ì/ì/g;s/←/←/g;s/·/·/g;s/−/−/g;s/–/–/g;s/ó/ó/g;s/ô/ô/g;s/ò/ò/g;s/õ/õ/g;s/ö/ö/g;s/£/£/g;s/′/′/g;s/″/″/g;s/»/»/g;s/→/→/g;s/ú/ú/g;s/↑/↑/g;s/¥/¥/g' {} +

followed by reading over every single line of the resulting diff and
fixing a whole bunch of false positives. The reason for this change is
given in <http://lists.wikimedia.org/pipermail/wikitech-l/2010-April/047617.html&gt;.
I cleared it with Tim and Brion on IRC before committing. It might
cause a few problems, but I tried to be careful; please report any
issues.

I skipped all messages files. I plan to make a follow-up commit that
alters wfMsgExt() with 'escapenoentities' to sanitize all the entities.
That way, the only messages that will be problems will be ones that
output raw HTML, and we want to get rid of those anyway.

For now, I skipped &zwnj; &thinsp; &ensp;. I'll catch these at another
pass. As with &nbsp;, I won't replace these with the actual UTF-8 (too
confusing), but these are pretty few, so maybe I'll be able to determine
by inspection that I don't have to replace them by hard-to-remember
numeric codes.

Also, to everyone who uses non-breaking spaces when they could use a
normal space, or nothing at all, or CSS padding: I hate you. Die.
Modified paths:
  • /branches/REL1_16/extensions/AbuseFilter/AbuseFilter.class.php (modified) (history)
  • /branches/REL1_16/extensions/AbuseFilter/Views/AbuseFilterViewExamine.php (modified) (history)
  • /branches/REL1_16/extensions/AbuseFilter/Views/AbuseFilterViewTestBatch.php (modified) (history)
  • /branches/REL1_16/extensions/AbuseFilter/Views/AbuseFilterViewTools.php (modified) (history)
  • /branches/REL1_16/extensions/AdminLinks/AdminLinks_body.php (modified) (history)
  • /branches/REL1_16/extensions/AmazonPlus/AmazonPlus.php (modified) (history)
  • /branches/REL1_16/extensions/BoardVote/BoardVote_body.php (modified) (history)
  • /branches/REL1_16/extensions/CentralAuth/SpecialGlobalGroupPermissions.php (modified) (history)
  • /branches/REL1_16/extensions/CharInsert/CharInsert.php (modified) (history)
  • /branches/REL1_16/extensions/CheckUser/CheckUser_body.php (modified) (history)
  • /branches/REL1_16/extensions/Citation/Citation.php (modified) (history)
  • /branches/REL1_16/extensions/CodeReview/backend/CodeCommentLinker.php (modified) (history)
  • /branches/REL1_16/extensions/CodeReview/ui/CodeReleaseNotes.php (modified) (history)
  • /branches/REL1_16/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)
  • /branches/REL1_16/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)
  • /branches/REL1_16/extensions/CodeReview/ui/SpecialCode.php (modified) (history)
  • /branches/REL1_16/extensions/Collection/Collection.hooks.php (modified) (history)
  • /branches/REL1_16/extensions/Collection/Collection.templates.php (modified) (history)
  • /branches/REL1_16/extensions/CommunityVoice/Modules/Ratings.php (modified) (history)
  • /branches/REL1_16/extensions/Configure/Configure.func.php (modified) (history)
  • /branches/REL1_16/extensions/Configure/specials/ConfigurationPage.php (modified) (history)
  • /branches/REL1_16/extensions/ConfigureWMF/ConfigureWMF.page.php (modified) (history)
  • /branches/REL1_16/extensions/Contributors/Contributors.page.php (modified) (history)
  • /branches/REL1_16/extensions/CountEdits/CountEdits.page.php (modified) (history)
  • /branches/REL1_16/extensions/Crosswiki/Block/CrosswikiBlock.page.php (modified) (history)
  • /branches/REL1_16/extensions/Data/SpecialData.php (modified) (history)
  • /branches/REL1_16/extensions/DataCenter/Views/Settings/Field.php (modified) (history)
  • /branches/REL1_16/extensions/DeleteQueue/Views/DeleteQueueViewCase.php (modified) (history)
  • /branches/REL1_16/extensions/Duplicator/Duplicator.page.php (modified) (history)
  • /branches/REL1_16/extensions/DynamicPageList/DPL.php (modified) (history)
  • /branches/REL1_16/extensions/DynamicPageList/DPLListMode.php (modified) (history)
  • /branches/REL1_16/extensions/DynamicPageList/DPLSetup.php (modified) (history)
  • /branches/REL1_16/extensions/DynamicPageList/DynamicPageListInclude.php (modified) (history)
  • /branches/REL1_16/extensions/EditConflict/EditConflict.php (modified) (history)
  • /branches/REL1_16/extensions/EditSimilar/EditSimilar.class.php (modified) (history)
  • /branches/REL1_16/extensions/EditUser/1.11/EditUser_body.php (modified) (history)
  • /branches/REL1_16/extensions/EditUser/1.12/EditUser_body.php (modified) (history)
  • /branches/REL1_16/extensions/EditUser/1.13/EditUser_body.php (modified) (history)
  • /branches/REL1_16/extensions/EditUser/1.14/EditUser_body.php (modified) (history)
  • /branches/REL1_16/extensions/EditUser/1.15/EditUser_body.php (modified) (history)
  • /branches/REL1_16/extensions/Editcount/SpecialEditcount_body.php (modified) (history)
  • /branches/REL1_16/extensions/EmailPage/EmailPage_body.php (modified) (history)
  • /branches/REL1_16/extensions/EmailPage/phpMailer_v2.1.0beta2/language/phpmailer.lang-de.php (modified) (history)
  • /branches/REL1_16/extensions/EmailPage/phpMailer_v2.1.0beta2/language/phpmailer.lang-et.php (modified) (history)
  • /branches/REL1_16/extensions/Farmer/SpecialFarmer.php (modified) (history)
  • /branches/REL1_16/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)
  • /branches/REL1_16/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)
  • /branches/REL1_16/extensions/FlaggedRevs/FlaggedRevsXML.php (modified) (history)
  • /branches/REL1_16/extensions/FlaggedRevs/specialpages/OldReviewedPages_body.php (modified) (history)
  • /branches/REL1_16/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php (modified) (history)
  • /branches/REL1_16/extensions/FlaggedRevs/specialpages/QualityOversight_body.php (modified) (history)
  • /branches/REL1_16/extensions/FlaggedRevs/specialpages/Stabilization_body.php (modified) (history)
  • /branches/REL1_16/extensions/FlaggedRevs/specialpages/StablePages_body.php (modified) (history)
  • /branches/REL1_16/extensions/FlaggedRevs/specialpages/UnreviewedPages_body.php (modified) (history)
  • /branches/REL1_16/extensions/FlaggedRevs/specialpages/UnstablePages_body.php (modified) (history)
  • /branches/REL1_16/extensions/FootNote/Footnote.php (modified) (history)
  • /branches/REL1_16/extensions/Gadgets/Gadgets.php (modified) (history)
  • /branches/REL1_16/extensions/Gadgets/SpecialGadgets.php (modified) (history)
  • /branches/REL1_16/extensions/ImageTagging/ImageTagging_body.php (modified) (history)
  • /branches/REL1_16/extensions/IndexFunction/SpecialIndex.php (modified) (history)
  • /branches/REL1_16/extensions/InputBox/InputBox.classes.php (modified) (history)
  • /branches/REL1_16/extensions/LastUserLogin/LastUserLogin_body.php (modified) (history)
  • /branches/REL1_16/extensions/LiquidThreads/classes/View.php (modified) (history)
  • /branches/REL1_16/extensions/LiquidThreads/compat/HTMLForm.php (modified) (history)
  • /branches/REL1_16/extensions/LiquidThreads/pages/TalkpageView.php (modified) (history)
  • /branches/REL1_16/extensions/Makesysop/SpecialMakesysop_body.php (modified) (history)
  • /branches/REL1_16/extensions/MetavidWiki/includes/specials/MV_SpecialMediaSearch.php (modified) (history)
  • /branches/REL1_16/extensions/MetavidWiki/languages/MV_Messages.php (modified) (history)
  • /branches/REL1_16/extensions/MetavidWiki/skins/mv_embed/example_usage/sample_page.php (modified) (history)
  • /branches/REL1_16/extensions/MetavidWiki/skins/mv_embed/example_usage/sample_playlists.php (modified) (history)
  • /branches/REL1_16/extensions/MetavidWiki/skins/mv_embed/example_usage/testing_page.php (modified) (history)
  • /branches/REL1_16/extensions/MiniPreview/MiniPreview.php (modified) (history)
  • /branches/REL1_16/extensions/MostRevisors/MostRevisors_body.php (modified) (history)
  • /branches/REL1_16/extensions/NewestPages/NewestPages.page.php (modified) (history)
  • /branches/REL1_16/extensions/News/NewsRenderer.php (modified) (history)
  • /branches/REL1_16/extensions/Nuke/SpecialNuke_body.php (modified) (history)
  • /branches/REL1_16/extensions/OpenID/SpecialOpenIDLogin.body.php (modified) (history)
  • /branches/REL1_16/extensions/Patroller/Patroller.class.php (modified) (history)
  • /branches/REL1_16/extensions/Plotters/SpecialPlotters.php (modified) (history)
  • /branches/REL1_16/extensions/Poem/Poem.php (modified) (history)
  • /branches/REL1_16/extensions/Poll/Poll_body.php (modified) (history)
  • /branches/REL1_16/extensions/Postcomment/SpecialPostcomment.php (modified) (history)
  • /branches/REL1_16/extensions/ProfileMonitor/ProfileMonitor.class.php (modified) (history)
  • /branches/REL1_16/extensions/ProofreadPage/ProofreadPage.php (modified) (history)
  • /branches/REL1_16/extensions/ProofreadPage/SpecialProofreadPages.php (modified) (history)
  • /branches/REL1_16/extensions/QPoll/qp_i18n.php (modified) (history)
  • /branches/REL1_16/extensions/QPoll/qp_question.php (modified) (history)
  • /branches/REL1_16/extensions/Quiz/Quiz.php (modified) (history)
  • /branches/REL1_16/extensions/RDF/Rdf.php (modified) (history)
  • /branches/REL1_16/extensions/RdfRedland/Rdf.php (modified) (history)
  • /branches/REL1_16/extensions/ReaderFeedback/ReaderFeedback.class.php (modified) (history)
  • /branches/REL1_16/extensions/ReaderFeedback/ReaderFeedback.hooks.php (modified) (history)
  • /branches/REL1_16/extensions/ReaderFeedback/ReaderFeedbackXML.php (modified) (history)
  • /branches/REL1_16/extensions/ReaderFeedback/specialpages/RatedPages_body.php (modified) (history)
  • /branches/REL1_16/extensions/ReaderFeedback/specialpages/RatingHistory_body.php (modified) (history)
  • /branches/REL1_16/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)
  • /branches/REL1_16/extensions/RefreshSpecial/RefreshSpecial.body.php (modified) (history)
  • /branches/REL1_16/extensions/Renameuser/SpecialRenameuser_body.php (modified) (history)
  • /branches/REL1_16/extensions/ReplaceText/SpecialReplaceText.php (modified) (history)
  • /branches/REL1_16/extensions/Review/Review.php (modified) (history)
  • /branches/REL1_16/extensions/SecurePoll/includes/ballots/ApprovalBallot.php (modified) (history)
  • /branches/REL1_16/extensions/SecurePoll/includes/ballots/ChooseBallot.php (modified) (history)
  • /branches/REL1_16/extensions/SecurePoll/includes/ballots/PreferentialBallot.php (modified) (history)
  • /branches/REL1_16/extensions/SecurePoll/includes/ballots/RadioRangeBallot.php (modified) (history)
  • /branches/REL1_16/extensions/SecurePoll/includes/talliers/HistogramRangeTallier.php (modified) (history)
  • /branches/REL1_16/extensions/SecurePoll/includes/talliers/PairwiseTallier.php (modified) (history)
  • /branches/REL1_16/extensions/SelectCategory/SelectCategoryFunctions.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticDrilldown/specials/SD_BrowseData.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticForms/specials/SF_CreateTemplate.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticForms/specials/SF_UploadWindow.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticForms/specials/SF_UploadWindow2.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/includes/SMW_DV_Linear.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/includes/SMW_DV_Number.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/includes/SMW_DV_String.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/includes/SMW_DV_Temperature.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/includes/SMW_DataValue.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/includes/SMW_Factbox.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/includes/SMW_GlobalFunctions.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/includes/articlepages/SMW_PropertyPage.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2_Queries.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/languages/SMW_LanguageIt.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/specials/Export/SMW_SpecialOWLExport.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/specials/QueryPages/SMW_SpecialProperties.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/specials/SMWAdmin/SMW_SpecialSMWAdmin.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialBrowse.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialPageProperty.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialSearchByProperty.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticNotifyMe/includes/SMW_NotifyProcessor.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticNotifyMe/includes/SNM_Initialize.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticNotifyMe/specials/SMWNotifyMe/SMWNotifyMe.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticResultFormats/Calendar/SRF_Calendar.php (modified) (history)
  • /branches/REL1_16/extensions/SemanticResultFormats/SRF_Settings.php (modified) (history)
  • /branches/REL1_16/extensions/SignDocument/SpecialCreateSignDocument.php (modified) (history)
  • /branches/REL1_16/extensions/SignDocument/SpecialSignDocument.php (modified) (history)
  • /branches/REL1_16/extensions/SiteMatrix/SiteMatrix_body.php (modified) (history)
  • /branches/REL1_16/extensions/SocialProfile/SystemGifts/SpecialSystemGiftManagerLogo.php (modified) (history)
  • /branches/REL1_16/extensions/SocialProfile/UserGifts/SpecialGiftManagerLogo.php (modified) (history)
  • /branches/REL1_16/extensions/SocialProfile/UserGifts/SpecialViewGift.php (modified) (history)
  • /branches/REL1_16/extensions/SocialProfile/UserGifts/SpecialViewGifts.php (modified) (history)
  • /branches/REL1_16/extensions/SpamDiffTool/SpamDiffTool.php (modified) (history)
  • /branches/REL1_16/extensions/Storyboard/specials/StoryReview/StoryReview_body.php (modified) (history)
  • /branches/REL1_16/extensions/SubPageList3/SubPageList3.php (modified) (history)
  • /branches/REL1_16/extensions/TableMod/TableMod.body.php (modified) (history)
  • /branches/REL1_16/extensions/TalkHere/TalkHereArticle.php (modified) (history)
  • /branches/REL1_16/extensions/Todo/SpecialTodo.php (modified) (history)
  • /branches/REL1_16/extensions/Translate/SpecialTranslations.php (modified) (history)
  • /branches/REL1_16/extensions/Translate/TranslateUtils.php (modified) (history)
  • /branches/REL1_16/extensions/Translate/tag/PageTranslationHooks.php (modified) (history)
  • /branches/REL1_16/extensions/TreeAndMenu/TreeAndMenu.php (modified) (history)
  • /branches/REL1_16/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php (modified) (history)
  • /branches/REL1_16/extensions/UsageStatistics/SpecialUserStats_body.php (modified) (history)
  • /branches/REL1_16/extensions/UserMerge/UserMerge_body.php (modified) (history)
  • /branches/REL1_16/extensions/Vote/Vote.page.php (modified) (history)
  • /branches/REL1_16/extensions/WhiteList/WhiteListEdit_body.php (modified) (history)
  • /branches/REL1_16/extensions/WikiArticleFeeds/WikiArticleFeeds.php (modified) (history)
  • /branches/REL1_16/extensions/WikiCategoryTagCloud/WikiCategoryTagCloud.php (modified) (history)
  • /branches/REL1_16/extensions/Wikidata/OmegaWiki/Editor.php (modified) (history)
  • /branches/REL1_16/extensions/Wikidata/OmegaWiki/forms.php (modified) (history)
  • /branches/REL1_16/extensions/Wikidata/util/voctrain/functions.php (modified) (history)
  • /branches/REL1_16/extensions/Wikilog/WikilogCommentsPage.php (modified) (history)
  • /branches/REL1_16/extensions/Wikilog/WikilogHooks.php (modified) (history)
  • /branches/REL1_16/extensions/Wikilog/WikilogItemPager.php (modified) (history)
  • /branches/REL1_16/extensions/experimental/SpecialData.php (modified) (history)
  • /branches/REL1_16/extensions/gis/GeoParam.php (modified) (history)
  • /branches/REL1_16/extensions/gis/neighbors.php (modified) (history)
  • /branches/REL1_16/extensions/phpbbData/phpbbData.php (modified) (history)
  • /branches/REL1_16/extensions/regexBlock/SpecialRegexBlock.php (modified) (history)
  • /branches/REL1_16/extensions/wikihiero/index.php (modified) (history)
  • /branches/REL1_16/extensions/wikihiero/wh_main.php (modified) (history)
  • /branches/REL1_16/extensions/wikiwyg/share/MediaWiki/extensions/CreatePage/SpecialCreatePage.php (modified) (history)
  • /branches/REL1_16/extensions/wikiwyg/share/MediaWiki/extensions/WikiwygEditing/WikiwygEditing.php (modified) (history)
  • /branches/REL1_16/phase3/config/Installer.php (modified) (history)
  • /branches/REL1_16/phase3/includes/Article.php (modified) (history)
  • /branches/REL1_16/phase3/includes/ChangeTags.php (modified) (history)
  • /branches/REL1_16/phase3/includes/ChangesList.php (modified) (history)
  • /branches/REL1_16/phase3/includes/EditPage.php (modified) (history)
  • /branches/REL1_16/phase3/includes/HTMLForm.php (modified) (history)
  • /branches/REL1_16/phase3/includes/HistoryPage.php (modified) (history)
  • /branches/REL1_16/phase3/includes/LogEventsList.php (modified) (history)
  • /branches/REL1_16/phase3/includes/MessageCache.php (modified) (history)
  • /branches/REL1_16/phase3/includes/Pager.php (modified) (history)
  • /branches/REL1_16/phase3/includes/Preferences.php (modified) (history)
  • /branches/REL1_16/phase3/includes/Sanitizer.php (modified) (history)
  • /branches/REL1_16/phase3/includes/Skin.php (modified) (history)
  • /branches/REL1_16/phase3/includes/Xml.php (modified) (history)
  • /branches/REL1_16/phase3/includes/diff/DifferenceEngine.php (modified) (history)
  • /branches/REL1_16/phase3/includes/diff/DifferenceInterface.php (modified) (history)
  • /branches/REL1_16/phase3/includes/parser/Parser.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialAllmessages.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialBlockip.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialBooksources.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialContributions.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialExport.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialIpblocklist.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialListusers.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialLockdb.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialMergeHistory.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialMovepage.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialProtectedpages.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialProtectedtitles.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialUndelete.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialUnlockdb.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialUpload.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialWatchlist.php (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialWhatlinkshere.php (modified) (history)
  • /branches/REL1_16/phase3/includes/templates/Userlogin.php (modified) (history)
  • /branches/REL1_16/phase3/profileinfo.php (modified) (history)
  • /branches/REL1_16/phase3/skins/Modern.php (modified) (history)
  • /branches/REL1_16/phase3/skins/MonoBook.php (modified) (history)
  • /branches/REL1_16/phase3/skins/Vector.php (modified) (history)

Follow-up revisions

RevisionCommit summaryAuthorDate
r66939Remove &zwnj; and &ensp; from trunk...simetrical00:42, 27 May 2010
r67090Remove most named character references from output...simetrical17:33, 30 May 2010

Comments

#Comment by Simetrical (talk | contribs)   02:13, 12 May 2010

Reverted in r66255, was meant for trunk.

Status & tagging log