r75600 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75599‎ | r75600 | r75601 >
Date:00:03, 28 October 2010
Author:hartman
Status:deferred
Tags:
Comment:
Removed source_wrap span around embed textarea. Was not being used for anything. Switch textarea from height:15px to rows=1.
Modified paths:
  • /branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/mw.PlayerControlBuilder.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/mw.PlayerControlBuilder.js
@@ -1144,15 +1144,12 @@
11451145
11461146 $shareInterface.append(
11471147
1148 - $j('<span />')
1149 - .addClass( 'source_wrap' )
1150 - .html(
1151 - $j( '<textarea />' )
1152 - .html( embed_code )
1153 - .click( function() {
1154 - $j( this ).select();
1155 - })
1156 - ),
 1148+ $j( '<textarea />' )
 1149+ .attr( 'rows', 1 )
 1150+ .html( embed_code )
 1151+ .click( function() {
 1152+ $j( this ).select();
 1153+ }),
11571154
11581155 $j('<br />'),
11591156 $j('<br />'),

Follow-up revisions

RevisionCommit summaryAuthorDate
r75601Follow up to r75600hartman00:04, 28 October 2010

Status & tagging log