| Index: trunk/extensions/CodeReview/backend/CodeRevision.php |
| — | — | @@ -449,7 +449,8 @@ |
| 450 | 450 | |
| 451 | 451 | // Make list of users to send emails to |
| 452 | 452 | $users = $this->getCommentingUsers(); |
| 453 | | - if ( $user = $this->getWikiUser() ) { |
| | 453 | + $user = $this->getWikiUser(); |
| | 454 | + if ( $user ) { |
| 454 | 455 | $users[$user->getId()] = $user; |
| 455 | 456 | } |
| 456 | 457 | // If we've got a spam list, send e-mails to it too |
| Index: trunk/extensions/CodeReview/api/ApiCodeComments.php |
| — | — | @@ -62,7 +62,7 @@ |
| 63 | 63 | |
| 64 | 64 | $count = 0; |
| 65 | 65 | $lastTimestamp = 0; |
| 66 | | - while ( $row = $comments->fetchObject() ) { |
| | 66 | + foreach ( $comments as $row ) { |
| 67 | 67 | if ( $count == $limit ) { |
| 68 | 68 | $this->setContinueEnumParameter( 'start', |
| 69 | 69 | wfTimestamp( TS_ISO_8601, $lastTimestamp ) ); |
| Index: trunk/extensions/CodeReview/api/ApiCodeRevisions.php |
| — | — | @@ -61,7 +61,7 @@ |
| 62 | 62 | |
| 63 | 63 | $count = 0; |
| 64 | 64 | $lastTimestamp = 0; |
| 65 | | - while ( $row = $revisions->fetchObject() ) { |
| | 65 | + foreach ( $revisions as $row ) { |
| 66 | 66 | if ( $count == $limit ) { |
| 67 | 67 | $this->setContinueEnumParameter( 'start', |
| 68 | 68 | wfTimestamp( TS_ISO_8601, $lastTimestamp ) ); |
| Index: trunk/extensions/CodeReview/ui/SpecialCode.php |
| — | — | @@ -17,7 +17,8 @@ |
| 18 | 18 | $this->setHeaders(); |
| 19 | 19 | $wgOut->addStyle( "$wgExtensionAssetsPath/CodeReview/codereview.css?$wgCodeReviewStyleVersion" ); |
| 20 | 20 | |
| 21 | | - if( $view = self::getViewFrom( $subpage ) ) { |
| | 21 | + $view = self::getViewFrom( $subpage ); |
| | 22 | + if( $view ) { |
| 22 | 23 | $view->execute(); |
| 23 | 24 | } else { |
| 24 | 25 | $wgOut->addWikiText( wfMsg( 'nosuchactiontext' ) ); |