r75559 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r75558‎ \| r75559 \| r75560 >
Date:	16:32, 27 October 2010
Author:	reedy
Status:	ok
Tags:
Comment:	*(bug 25639) Spurious "Revision 0 does not exist!" Can have no revid passed, which gives a 0. Missing one will still notify it doesn't exist
Modified paths:	/trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
—	—	@@ -39,7 +39,10 @@
40	40	return;
41	41	}
42	42	if ( !$this->mRev ) {
43		~~- $wgOut->addWikiMsg( 'code-rev-not-found', $this->mRevId );~~
	43	+ if ( $this->mRevId !== 0 ) {
	44	+ $wgOut->addWikiMsg( 'code-rev-not-found', $this->mRevId );
	45	+ }
	46	+
44	47	$view = new CodeRevisionListView( $this->mRepo->getName() );
45	48	$view->execute();
46	49	return;

Follow-up revisions

Revision	Commit summary	Author	Date
r76209	1.16wmf4: MFT r75559	catrope	18:58, 6 November 2010

Status & tagging log

15:58, 6 November 2010 😂 (talk | contribs) changed the status of r75559 [removed: new added: ok]