r75560 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75559‎ | r75560 | r75561 >
Date:16:48, 27 October 2010
Author:dale
Status:deferred
Tags:
Comment:
fixed undefined var in embedFrame
Modified paths:
  • /branches/MwEmbedStandAlone/mwEmbedFrame.php (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/mwEmbedFrame.php
@@ -153,7 +153,7 @@
154154 <body>
155155 <?
156156 // Check if we have a way to get sources:
157 - if( $this->apiTitleKey || $this->kentryid || count( $this->sources ) != 0 ) {
 157+ if( isset( $this->apiTitleKey ) || isset( $this->kentryid ) || count( $this->sources ) != 0 ) {
158158 echo $this->getVideoTag();
159159 } else {
160160 echo "Error: mwEmbedFrame missing required parameter for video sources";

Follow-up revisions

RevisionCommit summaryAuthorDate
r75574mwRemoteEmbed: <? -> <?php...hartman20:06, 27 October 2010

Status & tagging log