| Index: trunk/extensions/LiquidThreads/compat/HTMLForm.php |
| — | — | @@ -485,7 +485,7 @@ |
| 486 | 486 | static function flattenOptions( $options ) { |
| 487 | 487 | $flatOpts = array(); |
| 488 | 488 | |
| 489 | | - foreach ( $options as $key => $value ) { |
| | 489 | + foreach ( $options as $value ) { |
| 490 | 490 | if ( is_array( $value ) ) { |
| 491 | 491 | $flatOpts = array_merge( $flatOpts, self::flattenOptions( $value ) ); |
| 492 | 492 | } else { |
| Index: trunk/extensions/LiquidThreads/classes/View.php |
| — | — | @@ -824,7 +824,6 @@ |
| 825 | 825 | } |
| 826 | 826 | } |
| 827 | 827 | |
| 828 | | - $signature = null; |
| 829 | 828 | if ( isset( $data['signature'] ) ) { |
| 830 | 829 | $signature = $data['signature']; |
| 831 | 830 | } else { |
| — | — | @@ -921,7 +920,6 @@ |
| 922 | 921 | } |
| 923 | 922 | } |
| 924 | 923 | |
| 925 | | - $signature = null; |
| 926 | 924 | if ( isset( $data['signature'] ) ) { |
| 927 | 925 | $signature = $data['signature']; |
| 928 | 926 | } else { |
| — | — | @@ -984,7 +982,6 @@ |
| 985 | 983 | $error = $ot->moveTo( $nt, true, "Changed thread subject: $reason" ); |
| 986 | 984 | if ( $error !== true ) { |
| 987 | 985 | throw new MWException( "Got error $error trying to move pages." ); |
| 988 | | - return false; |
| 989 | 986 | } |
| 990 | 987 | |
| 991 | 988 | # Move the talk page if relevant, if it exists, and if we've been told to |
| — | — | @@ -1395,8 +1392,6 @@ |
| 1396 | 1393 | } |
| 1397 | 1394 | } |
| 1398 | 1395 | |
| 1399 | | - $thisCommand = ''; |
| 1400 | | - |
| 1401 | 1396 | if ( $enabled ) { |
| 1402 | 1397 | $thisCommand = Xml::tags( 'a', array( 'href' => $href, 'title' => $tooltip ), |
| 1403 | 1398 | $label ); |
| Index: trunk/extensions/LiquidThreads/classes/NewMessagesController.php |
| — | — | @@ -160,11 +160,9 @@ |
| 161 | 161 | // Pull users to update the message state for, including whether or not a |
| 162 | 162 | // user_message_state row exists for them, and whether or not to send an email |
| 163 | 163 | // notification. |
| 164 | | - $dbr = wfGetDB( DB_SLAVE ); |
| 165 | | - |
| 166 | 164 | $userIds = array(); |
| 167 | 165 | $notifyUsers = array(); |
| 168 | | - $obj = self::getRowsObject( $t ); |
| | 166 | + $res = self::getRowsObject( $t ); |
| 169 | 167 | foreach( $res as $row ) { |
| 170 | 168 | // Don't notify yourself |
| 171 | 169 | if ( $changeUser->getId() == $row->wl_user ) |
| Index: trunk/extensions/LiquidThreads/classes/ParserFunctions.php |
| — | — | @@ -25,8 +25,6 @@ |
| 26 | 26 | * most of the page can be cached, but the LiquidThreads dynamicism still works. |
| 27 | 27 | * Thanks to Tim for the idea. */ |
| 28 | 28 | static function lqtTalkPage( $parser, $args, $parser, $frame ) { |
| 29 | | - global $wgStyleVersion; |
| 30 | | - |
| 31 | 29 | $pout = $parser->getOutput(); |
| 32 | 30 | |
| 33 | 31 | // Prepare information. |
| — | — | @@ -62,8 +60,6 @@ |
| 63 | 61 | } |
| 64 | 62 | |
| 65 | 63 | static function lqtThread( $parser, $args, $parser, $frame ) { |
| 66 | | - global $wgStyleVersion; |
| 67 | | - |
| 68 | 64 | $pout = $parser->getOutput(); |
| 69 | 65 | |
| 70 | 66 | // Prepare information. |
| — | — | @@ -157,7 +153,6 @@ |
| 158 | 154 | $out->mLqtReplacements = array(); |
| 159 | 155 | } |
| 160 | 156 | |
| 161 | | - $processedReplacements = array(); |
| 162 | 157 | foreach( $pout->mLqtReplacements as $text => $details ) { |
| 163 | 158 | $result = ''; |
| 164 | 159 | |
| Index: trunk/extensions/LiquidThreads/classes/Thread.php |
| — | — | @@ -563,7 +563,6 @@ |
| 564 | 564 | // Load a list of threads in bulk, including all subthreads. |
| 565 | 565 | static function bulkLoad( $rows ) { |
| 566 | 566 | // Preload subthreads |
| 567 | | - $all_thread_ids = array(); |
| 568 | 567 | $top_thread_ids = array(); |
| 569 | 568 | $all_thread_rows = $rows; |
| 570 | 569 | $pageIds = array(); |
| — | — | @@ -725,8 +724,6 @@ |
| 726 | 725 | } |
| 727 | 726 | } |
| 728 | 727 | |
| 729 | | - $userIds = array_keys( $userIds ); |
| 730 | | - |
| 731 | 728 | // Pull link batch data. |
| 732 | 729 | $linkBatch->execute(); |
| 733 | 730 | |
| Index: trunk/extensions/LiquidThreads/classes/ThreadHistoryPager.php |
| — | — | @@ -76,8 +76,6 @@ |
| 77 | 77 | |
| 78 | 78 | $row = $this->mCurrentRow; |
| 79 | 79 | |
| 80 | | - $formatted = ''; |
| 81 | | - |
| 82 | 80 | switch( $name ) { |
| 83 | 81 | case 'th_timestamp': |
| 84 | 82 | $formatted = $wgLang->timeanddate( $value ); |
| Index: trunk/extensions/LiquidThreads/pages/ThreadPermalinkView.php |
| — | — | @@ -145,12 +145,12 @@ |
| 146 | 146 | $sk = $this->user->getSkin(); |
| 147 | 147 | $fragment = '#' . $this->anchorName( $this->thread ); |
| 148 | 148 | |
| 149 | | - if ( $this->thread->isHistorical() ) { |
| 150 | | - // TODO: Point to the relevant part of the archive. |
| 151 | | - $query = ''; |
| 152 | | - } else { |
| 153 | | - $query = ''; |
| 154 | | - } |
| | 149 | + //if ( $this->thread->isHistorical() ) { |
| | 150 | + / // TODO: Point to the relevant part of the archive. |
| | 151 | + // $query = ''; |
| | 152 | + //} else { |
| | 153 | + // $query = ''; |
| | 154 | + //} |
| 155 | 155 | |
| 156 | 156 | $talkpage = $this->thread->getTitle(); |
| 157 | 157 | $talkpage->setFragment( $fragment ); |
| Index: trunk/extensions/LiquidThreads/api/ApiFeedLQTThreads.php |
| — | — | @@ -128,8 +128,6 @@ |
| 129 | 129 | // What's included? |
| 130 | 130 | $types = (array)$params['type']; |
| 131 | 131 | |
| 132 | | - $msg = ''; |
| 133 | | - |
| 134 | 132 | if ( !count( array_diff( array( 'replies', 'newthreads' ), $types ) ) ) { |
| 135 | 133 | $msg = 'lqt-feed-title-all'; |
| 136 | 134 | } elseif ( in_array( 'replies', $types ) ) { |