r75521 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75520‎ | r75521 | r75522 >
Date:11:50, 27 October 2010
Author:catrope
Status:ok
Tags:
Comment:
Followup to r75266: remove warning "rvlimit may not be less than 1 (set to )" when rvparse is set but rvlimit is not set
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryRevisions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRevisions.php
@@ -210,6 +210,10 @@
211211 $this->generateXML = $params['generatexml'];
212212 $this->parseContent = $params['parse'];
213213 if ( $this->parseContent ) {
 214+ // Must manually initialize unset limit
 215+ if ( is_null( $limit ) ) {
 216+ $limit = 1;
 217+ }
214218 // We are only going to parse 1 revision per request
215219 $this->validateLimit( 'limit', $limit, 1, 1, 1 );
216220 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75266Added rvparse to parse revisions. For performance reasons if this option is u...btongminh16:41, 23 October 2010

Status & tagging log