r75470 MediaWiki - Code Review archive

Hmm, this doesn't seem logical to me. This would mean 2 things. 1 relying on the ajax routines to detect the proper parts in the url to encode, and 2 it means you are not passing a valid URI to ajax. All components in the data option of .ajax are indeed encoded by .ajax, but passing invalid uri's to the url param doesn't seem like a good idea to me.

Since wgFormattedNamespaces never contains reserved characters anyway, I think it's probably a moot issue. I did notice, however, that special (non-ASCII) characters are being escaped regardless. For example, "Spécial" always ends up as "Sp%C3%A9cial" in the resulting URL regardless of whether I use encodeURIComponent(), so I just assumed the same would be true of reserved characters. I don't actually know that this is the case, however, so you could be right. But like I said, since wgFormattedNamespaces is defined in the source (not from a query string parameter) and it never contains reserved URI characters (as far as I can tell), it probably doesn't matter anyway. If you think it should be changed back, though, just let me know. I'm not married to it either way.

It probably won't break indeed, but I've seen so many issues around this, that I prefer doing it properly. However, if you are already adding query params using bannerlistQuery, then why add other query params by hand to bannerListUrl ?

I need the slash unescaped for the squid regex.

reverted in r75889.