r75889 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75888‎ | r75889 | r75890 >
Date:23:22, 2 November 2010
Author:kaldari
Status:deferred
Tags:
Comment:
fix for r75470
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialBannerController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialBannerController.php
@@ -67,7 +67,7 @@
6868 var geoLocation = Geo.country; // pull the geo info
6969 }
7070 var bannerListQuery = $.param( { 'language': wgContentLanguage, 'project': wgNoticeProject, 'country': geoLocation } );
71 - var bannerListURL = wgScript + '?title=' + wgFormattedNamespaces[-1] + ':BannerListLoader&cache=/cn.js&' + bannerListQuery;
 71+ var bannerListURL = wgScript + '?title=' + encodeURIComponent(wgFormattedNamespaces[-1]) + ':BannerListLoader&cache=/cn.js&' + bannerListQuery;
7272 var request = $.ajax( {
7373 url: bannerListURL,
7474 dataType: 'json',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75470using encodeURIComponent is unneccessary since the text gets escaped anywaykaldari20:46, 26 October 2010

Status & tagging log