r75465 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75464‎ | r75465 | r75466 >
Date:19:57, 26 October 2010
Author:raymond
Status:reverted (Comments)
Tags:
Comment:
Partly revert of r75463: please keep the linebreaks in i18n files. They are not shown in the output but Translatewiki like them to make the translation process a bit easier.
Modified paths:
  • /trunk/extensions/Validator/Validator.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Validator/Validator.i18n.php
@@ -60,12 +60,16 @@
6161 'validator_list_error_invalid_range' => 'All values of parameter $1 must be between $2 and $3.',
6262 'validator-list-error-invalid-regex' => 'All values of parameter $1 must match this regular expression: $2.',
6363 'validator_list_error_invalid_argument' => 'One or more values for parameter $1 are invalid.',
64 - 'validator-list-error-accepts-only' => 'One or more values for parameter $1 are invalid. It only accepts {{PLURAL:$3|this value|these values}}: $2.',
65 - 'validator-list-error-accepts-only-omitted' => 'One or more values for parameter $1 are invalid. It only accepts {{PLURAL:$3|this value|these values}}: $2 (and $4 omitted {{PLURAL:$4|value|values}}).',
 64+ 'validator-list-error-accepts-only' => 'One or more values for parameter $1 are invalid.
 65+It only accepts {{PLURAL:$3|this value|these values}}: $2.',
 66+ 'validator-list-error-accepts-only-omitted' => 'One or more values for parameter $1 are invalid.
 67+It only accepts {{PLURAL:$3|this value|these values}}: $2 (and $4 omitted {{PLURAL:$4|value|values}}).',
6668
6769 // Criteria errors for single values & lists
68 - 'validator_error_accepts_only' => 'The value "$4" is not valid for parameter $1. It only accepts {{PLURAL:$3|this value|these values}}: $2.',
69 - 'validator-error-accepts-only-omitted' => 'The value "$2" is not valid for parameter $1. It only accepts {{PLURAL:$5|this value|these values}}: $3 (and $4 omitted {{PLURAL:$4|value|values}}).',
 70+ 'validator_error_accepts_only' => 'The value "$4" is not valid for parameter $1.
 71+It only accepts {{PLURAL:$3|this value|these values}}: $2.',
 72+ 'validator-error-accepts-only-omitted' => 'The value "$2" is not valid for parameter $1.
 73+It only accepts {{PLURAL:$5|this value|these values}}: $3 (and $4 omitted {{PLURAL:$4|value|values}}).',
7074
7175 'validator_list_omitted' => 'The {{PLURAL:$2|value|values}} $1 {{PLURAL:$2|has|have}} been omitted.',
7276 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r75506Revert r75465jeroendedauw10:23, 27 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75463Fixed issue with empty listsjeroendedauw19:46, 26 October 2010

Comments

#Comment by Jeroen De Dauw (talk | contribs)   19:59, 26 October 2010

I'm quite sure these ones are shown in the output, which is why I removed them:)

#Comment by Raymond (talk | contribs)   20:03, 26 October 2010

Hmmm to be fair I have not tested it because MediaWiki strips single linebreaks normally. Could you make a screenshot pls? I think it's easier for you to simulate a situation which shows these errors in action. Thanks.

#Comment by Jeroen De Dauw (talk | contribs)   21:47, 26 October 2010

Well, if you need proof: http://oi53.tinypic.com/28joev.jpg :)

Status & tagging log