r75466 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r75465
|
r75466
|
r75467
>
Date:
20:09, 26 October 2010
Author:
hashar
Status:
ok
Tags:
Comment:
Follow up
r75446
: simpler bench function, correct parenthesis.
Modified paths:
/trunk/phase3/maintenance/benchmarks/bench_wfIsWindows.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/maintenance/benchmarks/bench_wfIsWindows.php
—
—
@@ -20,16 +20,12 @@
21
21
}
22
22
23
23
static function is_win() {
24
- return substr( php_uname(), 0, 7 == 'Windows' );
24
+ return substr( php_uname(), 0, 7 ) == 'Windows' ;
25
25
}
26
26
27
27
// bench function 1
28
28
function wfIsWindows() {
29
- if( self::is_win() ) {
30
- return true;
31
- } else {
32
- return false;
33
- }
29
+ return self::is_win();
34
30
}
35
31
36
32
// bench function 2
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r75446
Follow up
r75429
: benchmark for wfIsWindows();...
hashar
17:21, 26 October 2010
Status & tagging log
21:12, 26 October 2010
Platonides
(
talk
|
contribs
)
changed the
status
of r75466
[
removed:
new
added:
ok]