r75367 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r75366‎ | r75367 | r75368 >
Date:17:12, 25 October 2010
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Unused since r74966 $wgHandheldStyle is handled by the resourceloader.
Modified paths:
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
——@@ -24,8 +24,6 @@
2525 $template = 'MonoBookTemplate', $useHeadElement = true;
2626
2727 function setupSkinUserCss( OutputPage $out ) {
28 - global $wgHandheldStyle;
29 -
3028 parent::setupSkinUserCss( $out );
3129
3230 $out->addModuleStyles( 'skins.monobook' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r781751.17: Back out Monobook-to-ResourceLoader port, has issues on IE6. This rever...catrope11:53, 10 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74966First shot at porting Monobook to Vector. The only non-straightforward part i...catrope20:35, 18 October 2010

Comments

#Comment by Siebrand (talk | contribs)   16:27, 26 October 2010

Is 'message' 'handheld.css' also obsolete, or does the skin 'handheld' still exist?

#Comment by Platonides (talk | contribs)   21:03, 26 October 2010

I understand that if you used a handheld style, you can add more styles inside the wiki in MediaWiki:handheld.css

ResourceLoader may be confusing me, though.

Status & tagging log