r75368 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75367‎ | r75368 | r75369 >
Date:17:45, 25 October 2010
Author:maxsem
Status:ok
Tags:
Comment:
Removed overzealous cleanup that was responsible for failures of tests in CruiseControl. Will investigate this further later, now fixing just enough to make things work.
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/search/SearchDbTest.php (modified) (history)
  • /trunk/phase3/maintenance/tests/phpunit/includes/search/SearchUpdateTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/search/SearchDbTest.php
@@ -26,10 +26,6 @@
2727
2828 function tearDown() {
2929 $this->removeSearchData();
30 - if ( !is_null( $this->db ) ) {
31 - wfGetLB()->closeConnecton( $this->db );
32 - }
33 - unset( $this->db );
3430 unset( $this->search );
3531 $GLOBALS['wgContLang'] = null;
3632 }
Index: trunk/phase3/maintenance/tests/phpunit/includes/search/SearchUpdateTest.php
@@ -74,14 +74,11 @@
7575 $wgLBFactoryConf['class'] = 'LBFactory_Simple';
7676 $wgDBservers = null;
7777 $wgContLang = Language::factory( 'en' );
78 - LBFactory::destroyInstance();
7978 }
8079
8180 function tearDown() {
8281 global $wgSearchType, $wgDBtype, $wgLBFactoryConf, $wgDBservers, $wgContLang;
8382
84 - LBFactory::destroyInstance();
85 -
8683 $wgSearchType = self::$searchType;
8784 $wgDBtype = self::$dbtype;
8885 $wgLBFactoryConf = self::$factoryconf;

Status & tagging log