r75349 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75348‎ | r75349 | r75350 >
Date:12:06, 25 October 2010
Author:wikibhasha.msr
Status:deferred (Comments)
Tags:
Comment:
bug id 25616,25643 closed | WikiBhasha keeps on searching for the corresponding target language article title, add Indonesian, Ukrainian and Vietnamese languages to wikibhasha supported language list, in feedback mail corrected the subject to wikibhasha beta
Modified paths:
  • /trunk/extensions/WikiBhasha/src/js/core/feedbackWindow.js (modified) (history)
  • /trunk/extensions/WikiBhasha/src/js/core/globalSettings.js (modified) (history)
  • /trunk/extensions/WikiBhasha/src/js/core/languageSelectionWindow.js (modified) (history)
  • /trunk/extensions/WikiBhasha/src/lang/de/strings.js (modified) (history)
  • /trunk/extensions/WikiBhasha/src/lang/en/strings.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiBhasha/src/lang/en/strings.js
@@ -96,7 +96,7 @@
9797 " for content contribution." +
9898 "<br><br>" +
9999 "Current WikiBhasha beta version: 1.0.0<br><br>" +
100 - "<a href=\"mailto:wikibfb@microsoft.com?subject=WikiBhasha Feedback\">Feedback to WikiBhasha team</a> welcome.",
 100+ "<a href=\"mailto:wikibfb@microsoft.com?subject=WikiBhasha beta Feedback\">Feedback to WikiBhasha team</a> welcome.",
101101 "<b>Supported Platforms: </b><P><P>\tIE 7/8 on Windows XP/Vista/Win7 and " +
102102 "Firefox 3.5 or above on Linux Fedora 11/12. " +
103103 "<b><P><P> Supported Languages: </b><P><P>\t" +
Index: trunk/extensions/WikiBhasha/src/lang/de/strings.js
@@ -95,7 +95,7 @@
9696 " for content contribution." +
9797 "<br><br>" +
9898 "Current WikiBhasha beta version: 1.0.0<br><br>" +
99 - "<a href=\"mailto:wikibfb@microsoft.com?subject=WikiBhasha Feedback\">Feedback to WikiBhasha team</a> welcome.",
 99+ "<a href=\"mailto:wikibfb@microsoft.com?subject=WikiBhasha beta Feedback\">Feedback to WikiBhasha team</a> welcome.",
100100 "<b>Supported Platforms: </b><P><P>\tIE 7/8 on Windows XP/Vista/Win7 and " +
101101 "Firefox 3.5 or above on Linux Fedora 11/12. " +
102102 "<b><P><P> Supported Languages: </b><P><P>\t" +
Index: trunk/extensions/WikiBhasha/src/js/core/feedbackWindow.js
@@ -97,7 +97,7 @@
9898
9999 $("#feedBackMessageDiv").html(wbLocal.feedbackThankYouMessage);
100100
101 - $("#wbFeedbackEmail").attr("href", "mailto:" + wbGlobalSettings.feedbackEmail + "?subject=WikiBhasha Feedback");
 101+ $("#wbFeedbackEmail").attr("href", "mailto:" + wbGlobalSettings.feedbackEmail + "?subject=WikiBhasha beta Feedback");
102102 }
103103 else {
104104 //always show the feedback form area and hide the thank you message.
@@ -193,7 +193,7 @@
194194 responseSmile=" (+): ";
195195 }
196196
197 - document.location.href=wbUtil.stringFormat("mailto:{0}?subject=WikiBhasha feedback{1}&body={2}",wbGlobalSettings.feedbackEmail, responseSmile, $feedbackTextValue);
 197+ document.location=wbUtil.stringFormat("mailto:{0}?subject=WikiBhasha beta feedback{1}&body={2}",wbGlobalSettings.feedbackEmail, responseSmile, $feedbackTextValue);
198198
199199 wbFeedback.isInvokedOnMainWindowExit = false;
200200 $("#" + wbFeedback.windowId).hide();
Index: trunk/extensions/WikiBhasha/src/js/core/globalSettings.js
@@ -141,6 +141,7 @@
142142 ['French', 'fr', 'Français'],
143143 ['Korean', 'ko', '한국어'],
144144 ['Hindi', 'hi', 'हिन्दी'],
 145+ ['Indonesian', 'id', 'Bahasa Indonesia'],
145146 ['Italian', 'it', 'italiano'],
146147 ['Hebrew', 'he', 'עברית'],
147148 ['HaitianCreole', 'ht', 'Kreyòlayisyen'],
@@ -160,6 +161,8 @@
161162 ['Swedish', 'sv', 'Svenska'],
162163 ['Thai', 'th', 'ภาษาไทย'],
163164 ['Turkish', 'tr', 'Türkç'],
 165+ ['Ukrainian', 'uk', 'Українська'],
 166+ ['Vietnamese', 'vi', 'Tiếng Việt'],
164167 ['ChineseSimplified', 'zh-CHS', '简体中文'],
165168 ['ChineseTraditional', 'zh-CHT', '繁體中文']
166169 ],
Index: trunk/extensions/WikiBhasha/src/js/core/languageSelectionWindow.js
@@ -151,7 +151,7 @@
152152 wbWikiSite.getTargetLanguageTitle(wbGlobalSettings.sourceLanguageCode, wbGlobalSettings.targetLanguageCode, wbGlobalSettings.sourceLanguageArticleTitle, function(data) {
153153 var isTitleBeingTranslated = false;
154154 //if article exists
155 - if (data.length > 0) {
 155+ if (data && data.length > 0) {
156156 wbGlobalSettings.targetLanguageArticleTitle = decodeURIComponent(($.trim(data)));
157157 $("#wbArticleTitleInput").hide();
158158 $("#wbArticleTitleLabel").hide();

Comments

#Comment by Reedy (talk | contribs)   14:54, 26 October 2010

Please use "bug 25616", "bug 25643" to link to bug versions

Status & tagging log