r75350 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75349‎ | r75350 | r75351 >
Date:12:06, 25 October 2010
Author:freakolowsky
Status:ok (Comments)
Tags:
Comment:
* fixed accidental revert of r75343
Modified paths:
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -186,10 +186,10 @@
187187 var $mFieldInfoCache = array();
188188
189189 function __construct( $server = false, $user = false, $password = false, $dbName = false,
190 - $failFunction = false, $flags = 0, $tablePrefix = 'get from global' )
 190+ $flags = 0, $tablePrefix = 'get from global' )
191191 {
192192 $tablePrefix = $tablePrefix == 'get from global' ? $tablePrefix : strtoupper( $tablePrefix );
193 - parent::__construct( $server, $user, $password, $dbName, $failFunction, $flags, $tablePrefix );
 193+ parent::__construct( $server, $user, $password, $dbName, $flags, $tablePrefix );
194194 wfRunHooks( 'DatabaseOraclePostInit', array( &$this ) );
195195 }
196196
@@ -219,14 +219,13 @@
220220 return true;
221221 }
222222
223 - static function newFromParams( $server, $user, $password, $dbName, $failFunction = false, $flags = 0, $tablePrefix )
 223+ static function newFromParams( $server, $user, $password, $dbName, $flags = 0, $tablePrefix )
224224 {
225 - return new DatabaseOracle( $server, $user, $password, $dbName, $failFunction, $flags, $tablePrefix );
 225+ return new DatabaseOracle( $server, $user, $password, $dbName, $flags, $tablePrefix );
226226 }
227227
228228 /**
229229 * Usually aborts on failure
230 - * If the failFunction is set to a non-zero integer, returns success
231230 */
232231 function open( $server, $user, $password, $dbName ) {
233232 if ( !function_exists( 'oci_connect' ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75343(bug 24853) Kill failFunction - Fixed! :Dreedy21:27, 24 October 2010

Comments

#Comment by Reedy (talk | contribs)   18:49, 25 October 2010

Cheers. No idea how I managed to revert myself

#Comment by MaxSem (talk | contribs)   18:51, 25 October 2010

No, he accidentally reverted you in r75346.

Status & tagging log