r75313 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75312‎ | r75313 | r75314 >
Date:15:24, 24 October 2010
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
(bug 23934) Groups defined in $wgRevokePermissions but not in $wgGroupPermissions now appear on Special:ListGroupRights
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialListgrouprights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListgrouprights.php
@@ -60,7 +60,11 @@
6161 '</tr>'
6262 );
6363
64 - foreach( $wgGroupPermissions as $group => $permissions ) {
 64+ $allGroups = array_merge( array_keys( $wgGroupPermissions ),
 65+ array_keys( $wgRevokePermissions ) );
 66+ foreach ( $allGroups as $group ) {
 67+ $permissions = isset( $wgGroupPermissions[$group] ) ?
 68+ $wgGroupPermissions[$group] : array();
6569 $groupname = ( $group == '*' ) ? 'all' : $group; // Replace * with a more descriptive groupname
6670
6771 $msg = wfMsg( 'group-' . $groupname );
Index: trunk/phase3/RELEASE-NOTES
@@ -360,6 +360,8 @@
361361 * (bug 25462) Fix double-escaping for section edit link tooltips
362362 * action=raw was removed for Special:Statistics. This information is still
363363 available via the API
 364+* (bug 23934) Groups defined in $wgRevokePermissions but not in
 365+ $wgGroupPermissions now appear on Special:ListGroupRights
364366
365367 === API changes in 1.17 ===
366368 * (bug 22738) Allow filtering by action type on query=logevent.

Follow-up revisions

RevisionCommit summaryAuthorDate
r75315Fix for r75313: add array_unique(), otherwise groups are listed twice if they...ialex16:05, 24 October 2010
r78404In the vein of r75313, get groups from the $wg(Add|Remove)Groups and $wgGroup...happy-melon22:45, 14 December 2010

Comments

#Comment by Happy-melon (talk | contribs)   22:34, 14 December 2010

We should add groups which are only specified through $wgAddGroups and $wgRemoveGroups as well.

Status & tagging log