r75315 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75314‎ | r75315 | r75316 >
Date:16:05, 24 October 2010
Author:ialex
Status:ok
Tags:
Comment:
Fix for r75313: add array_unique(), otherwise groups are listed twice if they are both in $wgGroupPermissions and $wgRevokePermissions
Modified paths:
  • /trunk/phase3/includes/specials/SpecialListgrouprights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListgrouprights.php
@@ -60,8 +60,8 @@
6161 '</tr>'
6262 );
6363
64 - $allGroups = array_merge( array_keys( $wgGroupPermissions ),
65 - array_keys( $wgRevokePermissions ) );
 64+ $allGroups = array_unique( array_merge( array_keys( $wgGroupPermissions ),
 65+ array_keys( $wgRevokePermissions ) ) );
6666 foreach ( $allGroups as $group ) {
6767 $permissions = isset( $wgGroupPermissions[$group] ) ?
6868 $wgGroupPermissions[$group] : array();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75313(bug 23934) Groups defined in $wgRevokePermissions but not in $wgGroupPermiss...btongminh15:24, 24 October 2010

Status & tagging log