r75308 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r75307‎ | r75308 | r75309 >
Date:14:56, 24 October 2010
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
Remove unnecessary @error surpressing operator. $pageSet is always defined and getGoodTitles() always returns an array
Modified paths:
  • /trunk/phase3/includes/api/ApiQuery.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQuery.php
——@@ -462,7 +462,7 @@
463463 // output with an ob
464464 ob_start();
465465 $exporter->openStream();
466 - foreach ( @$pageSet->getGoodTitles() as $title ) {
 466+ foreach ( $pageSet->getGoodTitles() as $title ) {
467467 if ( $title->userCanRead() ) {
468468 $exporter->pageByTitle( $title );
469469 }

Comments

#Comment by Hashar (talk | contribs)   15:27, 24 October 2010

The @ was introduced in r48629 by Catrope r1=48628&r2=48629&pathrev=75308 http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/api/ApiQuery.php?r1=48628&r2=48629&pathrev=75308

Status & tagging log