r75307 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75306‎ | r75307 | r75308 >
Date:13:52, 24 October 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
follow up to r75306
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_DataValue.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_QueryLanguage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_DataValue.php
@@ -401,13 +401,11 @@
402402 // Loop over the comparators to determine which one is used and what the actual value is.
403403 foreach ( SMWQueryLanguage::getComparatorStrings() as $srting ) {
404404 if ( strpos( $value, $srting ) === 0 ) {
405 - $comparatorString = substr( $value, 0, strlen( $srting ) );
 405+ $comparator = SMWQueryLanguage::getComparatorFromString( substr( $value, 0, strlen( $srting ) ) );
406406 $value = substr( $value, strlen( $srting ) );
407407 break;
408408 }
409409 }
410 -
411 - $comparator = SMWQueryLanguage::getComparatorFromString( $comparatorString, SMW_CMP_EQ );
412410 }
413411
414412 ///// Get methods /////
Index: trunk/extensions/SemanticMediaWiki/includes/SMW_QueryLanguage.php
@@ -94,7 +94,7 @@
9595 $comparators = array(
9696 '!~' => SMW_CMP_NLKE,
9797 '<<' => SMW_CMP_LESS,
98 - '>>' => SMW_CMP_GRTR,
 98+ '>>' => SMW_CMP_GRTR,
9999 '<' => $smwStrictComparators ? SMW_CMP_LESS : SMW_CMP_LEQ,
100100 '>' => $smwStrictComparators ? SMW_CMP_GRTR : SMW_CMP_GEQ,
101101 '≤' => SMW_CMP_LEQ,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75306follow up to r75295jeroendedauw13:27, 24 October 2010

Status & tagging log