r75143 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75142‎ | r75143 | r75144 >
Date:12:51, 21 October 2010
Author:hartman
Status:deferred
Tags:
Comment:
encodeURIComponent instead of escape for data uri's
Modified paths:
  • /branches/MwEmbedStandAlone/modules/Sequencer/mw.Sequencer.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/Sequencer/mw.Sequencer.js
@@ -201,7 +201,7 @@
202202 if( ! xmlString ){
203203 xmlString = this.getSmil().getXMLString();
204204 }
205 - return 'data:text/xml;charset=utf-8,' + escape( xmlString );
 205+ return 'data:text/xml;charset=utf-8,' + encodeURIComponent( xmlString );
206206 },
207207 getNewSmilXML: function( ){
208208 var title = ( this.getOption('title') ) ?
@@ -380,4 +380,4 @@
381381 }
382382 }
383383
384 -} )( window.mw );
\ No newline at end of file
 384+} )( window.mw );

Follow-up revisions

RevisionCommit summaryAuthorDate
r75144Follow up to r75143. decodeURIComponent instead of unescape of data URIshartman13:00, 21 October 2010

Status & tagging log