r75144 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75143‎ | r75144 | r75145 >
Date:13:00, 21 October 2010
Author:hartman
Status:deferred
Tags:
Comment:
Follow up to r75143. decodeURIComponent instead of unescape of data URIs
Modified paths:
  • /branches/MwEmbedStandAlone/modules/SmilPlayer/mw.Smil.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/SmilPlayer/mw.Smil.js
@@ -77,7 +77,7 @@
7878 if( url.indexOf( dataUrlKey ) === 0 ){
7979 // Load the smil document from the data url:
8080 _this.loadFromString(
81 - unescape( url.substr( dataUrlKey.length ) )
 81+ decodeURIComponent( url.substr( dataUrlKey.length ) )
8282 );
8383 // xxx Note we could in theory have a data url with remote 'context'
8484 // ie cross domain smil loading ( for now assume document.URL context for data urls )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75143encodeURIComponent instead of escape for data uri'shartman12:51, 21 October 2010

Status & tagging log