r75020 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75019‎ | r75020 | r75021 >
Date:18:07, 19 October 2010
Author:hashar
Status:ok (Comments)
Tags:
Comment:
3 new keys since, disabled & project:
* since: is roughly the svn account creation date
* disabled: roughly the svn account deletion date
* project: describe the area of work
Modified paths:
  • /USERINFO/80686 (modified) (history)
  • /USERINFO/a_engels (modified) (history)
  • /USERINFO/aaron (modified) (history)
  • /USERINFO/aj (added) (history)
  • /USERINFO/alexsh (modified) (history)
  • /USERINFO/allyunion (modified) (history)
  • /USERINFO/alnokta (modified) (history)
  • /USERINFO/amir (modified) (history)
  • /USERINFO/aude (modified) (history)
  • /USERINFO/awjrichards (modified) (history)
  • /USERINFO/bawolff (modified) (history)
  • /USERINFO/bhagya (added) (history)
  • /USERINFO/btongminh (modified) (history)
  • /USERINFO/catrope (modified) (history)
  • /USERINFO/cdangerville (modified) (history)
  • /USERINFO/churchofemacs (modified) (history)
  • /USERINFO/cobi (modified) (history)
  • /USERINFO/collinj (modified) (history)
  • /USERINFO/conrad (modified) (history)
  • /USERINFO/cydeweys (modified) (history)
  • /USERINFO/dale (modified) (history)
  • /USERINFO/dantman (modified) (history)
  • /USERINFO/david (modified) (history)
  • /USERINFO/devunt (modified) (history)
  • /USERINFO/dfinzer (modified) (history)
  • /USERINFO/diederik (modified) (history)
  • /USERINFO/eloy (modified) (history)
  • /USERINFO/emil (modified) (history)
  • /USERINFO/emufarmers (modified) (history)
  • /USERINFO/ezachte (modified) (history)
  • /USERINFO/fabianh (added) (history)
  • /USERINFO/fde (modified) (history)
  • /USERINFO/foxtrott (modified) (history)
  • /USERINFO/gbruin (modified) (history)
  • /USERINFO/gerrit (modified) (history)
  • /USERINFO/greg (modified) (history)
  • /USERINFO/gurch (modified) (history)
  • /USERINFO/gwicke (added) (history)
  • /USERINFO/happy-melon (modified) (history)
  • /USERINFO/happydog (modified) (history)
  • /USERINFO/hcatlin (modified) (history)
  • /USERINFO/hooft (modified) (history)
  • /USERINFO/huji (modified) (history)
  • /USERINFO/husky (modified) (history)
  • /USERINFO/ialex (modified) (history)
  • /USERINFO/inez (modified) (history)
  • /USERINFO/jacquesroy7 (added) (history)
  • /USERINFO/jan (modified) (history)
  • /USERINFO/janpaul123 (modified) (history)
  • /USERINFO/jdpond (modified) (history)
  • /USERINFO/jeblad (modified) (history)
  • /USERINFO/jeroendedauw (modified) (history)
  • /USERINFO/jnatividad (modified) (history)
  • /USERINFO/jojo (modified) (history)
  • /USERINFO/jprilusky (modified) (history)
  • /USERINFO/kaldari (modified) (history)
  • /USERINFO/kim (modified) (history)
  • /USERINFO/kipcool (modified) (history)
  • /USERINFO/leogregianin (modified) (history)
  • /USERINFO/leon (modified) (history)
  • /USERINFO/lhridley (modified) (history)
  • /USERINFO/liangent (modified) (history)
  • /USERINFO/malvineous (added) (history)
  • /USERINFO/mfarag (modified) (history)
  • /USERINFO/mglaser (modified) (history)
  • /USERINFO/mgrabovsky (modified) (history)
  • /USERINFO/mikaellindmark (modified) (history)
  • /USERINFO/millosh (added) (history)
  • /USERINFO/misza13 (modified) (history)
  • /USERINFO/mkroetzsch (modified) (history)
  • /USERINFO/mulligen (modified) (history)
  • /USERINFO/multichill (modified) (history)
  • /USERINFO/nadeesha (modified) (history)
  • /USERINFO/nephele (modified) (history)
  • /USERINFO/nicdumz (added) (history)
  • /USERINFO/nikola (modified) (history)
  • /USERINFO/nimishg (modified) (history)
  • /USERINFO/ning (modified) (history)
  • /USERINFO/overlordq (modified) (history)
  • /USERINFO/papyromancer (added) (history)
  • /USERINFO/peter17 (modified) (history)
  • /USERINFO/philip (modified) (history)
  • /USERINFO/questpc (modified) (history)
  • /USERINFO/quistnix (modified) (history)
  • /USERINFO/rainman (modified) (history)
  • /USERINFO/raymond (modified) (history)
  • /USERINFO/reedy (modified) (history)
  • /USERINFO/rememberthedot (modified) (history)
  • /USERINFO/rfong (modified) (history)
  • /USERINFO/rikwade (modified) (history)
  • /USERINFO/robchurch (modified) (history)
  • /USERINFO/robin (modified) (history)
  • /USERINFO/robla (modified) (history)
  • /USERINFO/roman (modified) (history)
  • /USERINFO/rotem (modified) (history)
  • /USERINFO/russblau (modified) (history)
  • /USERINFO/sanyamgoyal (added) (history)
  • /USERINFO/saper (modified) (history)
  • /USERINFO/sergeychernyshev (modified) (history)
  • /USERINFO/shinjiman (modified) (history)
  • /USERINFO/shizhao (modified) (history)
  • /USERINFO/shmichael (modified) (history)
  • /USERINFO/siebrand (modified) (history)
  • /USERINFO/soxred93 (modified) (history)
  • /USERINFO/strainu (modified) (history)
  • /USERINFO/straussd (modified) (history)
  • /USERINFO/suuch (modified) (history)
  • /USERINFO/svemir (modified) (history)
  • /USERINFO/svip (modified) (history)
  • /USERINFO/tango (modified) (history)
  • /USERINFO/than4213 (modified) (history)
  • /USERINFO/thedevilonline (modified) (history)
  • /USERINFO/tisane (modified) (history)
  • /USERINFO/valhallasw (modified) (history)
  • /USERINFO/vrandezo (modified) (history)
  • /USERINFO/vyznev (modified) (history)
  • /USERINFO/warddr (modified) (history)
  • /USERINFO/whiteknight (modified) (history)
  • /USERINFO/wikipedian (modified) (history)
  • /USERINFO/wwalc (modified) (history)
  • /USERINFO/xqt (modified) (history)
  • /USERINFO/yaauie (added) (history)
  • /USERINFO/yaron (modified) (history)
  • /USERINFO/yurik (modified) (history)

Comments

#Comment by Hashar (talk | contribs)   18:08, 19 October 2010

Information comes from historical mails from Tim or Brion announcing new committers.

#Comment by Brion VIBBER (talk | contribs)   18:12, 19 October 2010

nice!

#Comment by Nikerabbit (talk | contribs)   19:01, 19 October 2010

How many users were left out in this list?

#Comment by Hashar (talk | contribs)   06:17, 21 October 2010

Anyone added before 2005 roughly. I have not added users with no commits.

@Nikerabbit :

122 users now have 'since'

90 needs one :

$ egrep -L ^since USERINFO/* | wc -l
     90
$
#Comment by MZMcBride (talk | contribs)   06:21, 21 October 2010

Have these extra fields been added to <http://svn.wikimedia.org/users.php>? Should they be?

#Comment by Hashar (talk | contribs)   17:35, 21 October 2010

Maybe users.php should be merged with the CodeReview extension. We could use metadata to improve the "reviewer experience" :-b

#Comment by P858snake (talk | contribs)   09:37, 21 October 2010

Was there any discussion on what the keys/labels should be before hand? their group would probably be more suited than "project". "since" and "disabled" are not all that descriptive unless you know what they stand for.

#Comment by Hashar (talk | contribs)   17:32, 21 October 2010

see the commit message :

  • since: is roughly the svn account creation date
  • disabled: roughly the svn account deletion date
  • project: describe the area of work

The project items comes directly from Brion & Tim announcements. They might have changed with time. I added the since and disabled so we could eventually clean up unused accounts later. Although one can just parse the svn log :)

#Comment by P858snake (talk | contribs)   22:36, 21 October 2010

I knew what they meant, i did read that, but I'm referring to people that haven't seen this commit message as to why they may be ambiguous. And I believe cleaning up accounts has been mentioned before and can't be done for various reasons.

#Comment by Hashar (talk | contribs)   06:42, 22 October 2010

Maybe add the keywords list to : http://www.mediawiki.org/wiki/USERINFO

#Comment by Krinkle (talk | contribs)   16:19, 1 November 2010
#Comment by Hashar (talk | contribs)   20:02, 2 November 2010

Looks great! You might want to talk about it with Tim and replace the old one :-)

Status & tagging log