r75019 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75018‎ | r75019 | r75020 >
Date:17:52, 19 October 2010
Author:tparscal
Status:ok
Tags:
Comment:
Reverts r75018, and does what that commit was supposed to do.
Modified paths:
  • /trunk/phase3/includes/ResourceLoader.php (modified) (history)
  • /trunk/phase3/resources/Resources.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ResourceLoader.php
@@ -301,6 +301,9 @@
302302 }
303303
304304 $response = $this->makeModuleResponse( $context, $modules, $missing );
 305+ if ( $context->getDebug() && strlen( $warnings = ob_get_contents() ) ) {
 306+ $response .= "/*\n$warnings\n*/";
 307+ }
305308 // Clear any warnings from the buffer
306309 ob_clean();
307310 echo $response;
Index: trunk/phase3/resources/Resources.php
@@ -11,9 +11,6 @@
1212
1313 /* Skins */
1414
15 - 'vector2e2e2' => new ResourceLoaderFileModule(
16 - array( 'styles' => array( 'skins/vector/screen2e2e2.css' => array( 'media' => 'screen' ) ) )
17 - ),
1815 'vector' => new ResourceLoaderFileModule(
1916 array( 'styles' => array( 'skins/vector/screen.css' => array( 'media' => 'screen' ) ) )
2017 ),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75018Improves on r74964 by including PHP warnings emitted during a ResourceLoader ...tparscal17:48, 19 October 2010

Status & tagging log