r75018 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75017‎ | r75018 | r75019 >
Date:17:48, 19 October 2010
Author:tparscal
Status:reverted (Comments)
Tags:
Comment:
Improves on r74964 by including PHP warnings emitted during a ResourceLoader response in a comment at the end of the response - only while in debug mode.
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/Resources.php
@@ -11,6 +11,9 @@
1212
1313 /* Skins */
1414
 15+ 'vector2e2e2' => new ResourceLoaderFileModule(
 16+ array( 'styles' => array( 'skins/vector/screen2e2e2.css' => array( 'media' => 'screen' ) ) )
 17+ ),
1518 'vector' => new ResourceLoaderFileModule(
1619 array( 'styles' => array( 'skins/vector/screen.css' => array( 'media' => 'screen' ) ) )
1720 ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r75019Reverts r75018, and does what that commit was supposed to do.tparscal17:52, 19 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74964ResourceLoader: Clear warnings before echo'ing outputcatrope20:16, 18 October 2010

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   17:51, 19 October 2010

CRAP! This was not what I meant to commit...

Status & tagging log