r74681 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74680‎ | r74681 | r74682 >
Date:18:14, 12 October 2010
Author:maxsem
Status:ok (Comments)
Tags:
Comment:
Follow-up r74628: convert two remaining calls of patchPath()
Modified paths:
  • /trunk/phase3/maintenance/patchSql.php (modified) (history)
  • /trunk/phase3/maintenance/tests/phpunit/phpunit.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/phpunit.php
@@ -23,12 +23,6 @@
2424 // To prevent tests from failing with SQLite, we need to turn database caching off
2525 $wgCaches[CACHE_DB] = false;
2626
27 -$targetFile = wfIsWindows() ? 'phpunit.php' : 'phpunit';
28 -$pathSeparator = wfIsWindows() ? ';' : ':';
29 -
30 -$folders = explode( $pathSeparator, getenv('PATH') );
31 -
3227 require_once( 'PHPUnit/TextUI/Command.php' );
33 -define( 'PHPUnit_MAIN_METHOD', 'PHPUnit_TextUI_Command::main' );
3428 PHPUnit_TextUI_Command::main();
3529
Index: trunk/phase3/maintenance/patchSql.php
@@ -39,8 +39,8 @@
4040 foreach ( $this->mArgs as $arg ) {
4141 $files = array(
4242 $arg,
43 - DatabaseBase::patchPath( $arg ),
44 - DatabaseBase::patchPath( "patch-$arg.sql" ),
 43+ $dbw->patchPath( $arg ),
 44+ $dbw->patchPath( "patch-$arg.sql" ),
4545 );
4646 foreach ( $files as $file ) {
4747 if ( file_exists( $file ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r74683Piece I was going to commit in r74681maxsem18:16, 12 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74628Turned Database::patchPath() into a member function, less globals to care aboutmaxsem15:29, 11 October 2010

Comments

#Comment by MaxSem (talk | contribs)   18:16, 12 October 2010

Oops, phpunit.php was committed by mistake. Luckily, I was going to commit it anyway.

Status & tagging log