r74682 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74681‎ | r74682 | r74683 >
Date:18:15, 12 October 2010
Author:tparscal
Status:ok
Tags:
Comment:
Improves on r69445 by removing unneeded conditional. Also fixes a comment typo.
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)
  • /trunk/phase3/resources/mediawiki/mediawiki.log.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -252,7 +252,7 @@
253253 // Resolves dynamic loader function and replaces it with it's own results
254254 if ( typeof registry[module].dependencies === 'function' ) {
255255 registry[module].dependencies = registry[module].dependencies();
256 - // Gaurantees the module's dependencies are always in an array
 256+ // Ensures the module's dependencies are always in an array
257257 if ( typeof registry[module].dependencies !== 'object' ) {
258258 registry[module].dependencies = [registry[module].dependencies];
259259 }
Index: trunk/phase3/resources/mediawiki/mediawiki.log.js
@@ -45,17 +45,16 @@
4646 } )
4747 .appendTo( $( 'body' ) );
4848 }
49 - if ( $log.length ) {
50 - $log.append(
51 - $( '<div>' + string + '</div>' )
52 - .css( {
53 - 'border-bottom': 'solid 1px #DDDDDD',
54 - 'font-size': 'small',
55 - 'font-family': 'monospace',
56 - 'padding': '0.125em 0.25em'
57 - } )
58 - );
59 - }
 49+ $log.append(
 50+ $( '<div></div>' )
 51+ .text( string )
 52+ .css( {
 53+ 'border-bottom': 'solid 1px #DDDDDD',
 54+ 'font-size': 'small',
 55+ 'font-family': 'monospace',
 56+ 'padding': '0.125em 0.25em'
 57+ } )
 58+ );
6059 }
6160 }
6261 } );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69445Merged a few modules into mw.jstparscal21:57, 16 July 2010

Status & tagging log