r74301 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74300‎ | r74301 | r74302 >
Date:14:18, 5 October 2010
Author:jeroendedauw
Status:deferred (Comments)
Tags:
Comment:
Follow up to r74295
Modified paths:
  • /trunk/extensions/Validator/includes/Validator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Validator/includes/Validator.php
@@ -242,7 +242,7 @@
243243
244244 while ( $paramName = array_shift( $this->paramsTohandle ) ) {
245245 $parameter = $this->parameters[$paramName];
246 -
 246+
247247 $setUservalue = $this->attemptToSetUserValue( $parameter );
248248
249249 // If the parameter is required but not provided, register a fatal error and stop processing.
@@ -312,12 +312,14 @@
313313 }
314314 }
315315
316 - $dependencyList[$paramName] = array();
 316+ $dependencyList[$paramName] = $dependencies;
317317 }
318 -
 318+//static $foobar = 0;
 319+//$foobar++;
319320 $sorter = new TopologicalSort( $dependencyList, true );
320 -
 321+ //if ($foobar>16){var_dump($this->paramsTohandle);}
321322 $this->paramsTohandle = $sorter->doSort();
 323+ //if ($foobar>16){var_dump($this->paramsTohandle);exit;}
322324 }
323325
324326 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74295Changes for 0.4 - fixed issue with handling parameter dependenciesjeroendedauw11:51, 5 October 2010

Comments

#Comment by Brion VIBBER (talk | contribs)   14:33, 5 October 2010

I'm guessing the commented-out code can go. :)

#Comment by Jeroen De Dauw (talk | contribs)   14:40, 5 October 2010

Yes, next commit I make for this extension.

Status & tagging log