r74300 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74299‎ | r74300 | r74301 >
Date:14:14, 5 October 2010
Author:raymond
Status:resolved
Tags:
Comment:
Fix installation instructions
Fix extension credits
Add a FIXME
Some message tweaks for consistency
BTW: Running trunk and adding <comments /> at the end of a page in NS0, I get:
* A lot of UNIQ...QINU all over the page
* @ENCODED@PGRpdiBpZD..... ==@ENCODED@ at the end of the page
Modified paths:
  • /trunk/extensions/ArticleComments/ArticleComments.i18n.php (modified) (history)
  • /trunk/extensions/ArticleComments/ArticleComments.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleComments/ArticleComments.php
@@ -16,7 +16,7 @@
1717 * 1. Drop this script (ArticleComments.php) in $IP/extensions
1818 * Note: $IP is your MediaWiki install dir.
1919 * 2. Enable the extension by adding this line to your LocalSettings.php:
20 - * require_once('extensions/ArticleComments.php');
 20+ * require_once( "$IP/extensions/ArticleComments/ArticleComments.php" );
2121 * Usage:
2222 * Once installed, you may utilize ArticleComments by adding the following flag in the article text:
2323 * <comments />
@@ -76,10 +76,11 @@
7777
7878 # Credits
7979 $wgExtensionCredits['other'][] = array(
 80+ 'path' => __FILE__,
8081 'name' => 'ArticleComments',
81 - 'author' => 'Jim R. Wilson - wilson.jim.r &lt;at&gt; gmail.com',
 82+ 'author' => 'Jim R. Wilson - wilson.jim.r <at> gmail.com',
8283 'url' => 'http://jimbojw.com/wiki/index.php?title=ArticleComments',
83 - 'description' => 'Enables comment sections on article pages.',
 84+ 'descriptionmsg' => 'article-comments-desc',
8485 'version' => '0.5'
8586 );
8687
@@ -112,6 +113,7 @@
113114 # Sets up special page to handle comment submission
114115 $wgExtensionFunctions[] = 'setupSpecialProcessComment';
115116
 117+// FIXME: Use of SpecialPage::addPage is deprecated.
116118 function setupSpecialProcessComment() {
117119 SpecialPage::addPage( new SpecialPage( 'ProcessComment', '', true, 'specialProcessComment', false ) );
118120 }
Index: trunk/extensions/ArticleComments/ArticleComments.i18n.php
@@ -9,6 +9,7 @@
1010 $messages = array();
1111
1212 $messages['en'] = array(
 13+ 'article-comments-desc' => 'Enables comment sections on article pages',
1314 'article-comments-title-string' => 'title',
1415 'article-comments-name-string' => 'Name',
1516 'article-comments-name-field' => 'Name (required):',
@@ -20,7 +21,7 @@
2122 'article-comments-leave-comment-link' => 'Leave a comment ...',
2223 'article-comments-invalid-field' => 'The $1 provided <nowiki>[$2]</nowiki> is invalid.',
2324 'article-comments-required-field' => '$1 field is required.',
24 - 'article-comments-submission-failed' => 'Comment Submission Failed',
 25+ 'article-comments-submission-failed' => 'Comment submission failed',
2526 'article-comments-failure-reasons' => 'Sorry, your comment submission failed for the following reason(s):',
2627 'article-comments-no-comments' => 'Sorry, the article "[[$1]]" is not accepting comments at this time.',
2728 'article-comments-talk-page-starter' => "<noinclude>Comments on [[$1]]\n<comments />\n----- __NOEDITSECTION__</noinclude>\n",
@@ -33,7 +34,7 @@
3435 'article-comments-user-is-blocked' => 'Your user account is currently blocked from editing [[$1]].',
3536 'article-comments-new-comment' => "\n== \$1 ==\n\n<div class='commentBlock'>\n\$2\n\n--\$3 \$4\n</div>\n",
3637 'article-comments-no-spam' => 'At least one of the submitted fields was flagged as spam.',
37 - 'processcomment' => 'Process Article Comment',
 38+ 'processcomment' => 'Process qrticle comment',
3839 );
3940
4041 $messages['qqq'] = array(

Follow-up revisions

RevisionCommit summaryAuthorDate
r74303Follow-up r74300: Typoraymond14:19, 5 October 2010

Status & tagging log