r73942 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r73941‎ | r73942 | r73943 >
Date:12:09, 29 September 2010
Author:maxsem
Status:reverted (Comments)
Tags:
Comment:
Revert r73887. I blame Nikerabbit!
Modified paths:
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseSqlite.php
——@@ -88,7 +88,7 @@
8989 } catch ( PDOException $e ) {
9090 $err = $e->getMessage();
9191 }
92 - if ( !$this->mConn ) {
 92+ if ( $this->mConn === false ) {
9393 wfDebug( "DB connection error: $err\n" );
9494 if ( !$this->mFailFunction ) {
9595 throw new DBConnectionError( $this, $err );

Follow-up revisions

RevisionCommit summaryAuthorDate
r75227Revert r73942, which was itself a revert of r73887. After r75213 it will not ...maxsem09:59, 23 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73887DatabaseSqlite: better check for error. Noticed by Nikerabbitmaxsem13:46, 28 September 2010

Comments

#Comment by 😂 (talk | contribs)   12:36, 29 September 2010

This is in regards to broken testing on ci.tesla. All the Sqlite tests were failing with the following: "DBConnectionError: DB connection error: safe_mode/open_basedir prohibits opening"

Of course neither safe_mode or open_basedir is setup on ci.tesla. Couldn't replicate locally :)

#Comment by Nikerabbit (talk | contribs)   14:24, 29 September 2010

Hey! I reported valid bug and now you have commit message which has no substance what so ever :). But seriously, this version is also broken because it doesn't catch if sqlite pdo driver is not enabled, instead it fails later on call to method quote() on non-object.

Status & tagging log