r75227 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r75226‎ \| r75227 \| r75228 >
Date:	09:59, 23 October 2010
Author:	maxsem
Status:	ok
Tags:
Comment:	Revert r73942, which was itself a revert of r73887. After r75213 it will not cause additional test failures.
Modified paths:	/trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseSqlite.php
—	—	@@ -88,7 +88,7 @@
89	89	} catch ( PDOException $e ) {
90	90	$err = $e->getMessage();
91	91	}
92		~~- if ( $this->mConn === false ) {~~
	92	+ if ( !$this->mConn ) {
93	93	wfDebug( "DB connection error: $err\n" );
94	94	if ( !$this->mFailFunction ) {
95	95	throw new DBConnectionError( $this, $err );

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r73887	DatabaseSqlite: better check for error. Noticed by Nikerabbit	maxsem	13:46, 28 September 2010
r73942	Revert r73887. I blame Nikerabbit!	maxsem	12:09, 29 September 2010
r75213	PDO doesn't seem to like opening nothing	maxsem	19:48, 22 October 2010

Status & tagging log

19:44, 4 November 2010 😂 (talk | contribs) changed the status of r75227 [removed: new added: ok]